From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/2] btrfs-progs: make "btrfstune -S1" to reject fs with dirty log
Date: Mon, 25 Apr 2022 14:11:31 +0200 [thread overview]
Message-ID: <20220425121130.GN18596@twin.jikos.cz> (raw)
In-Reply-To: <cover.1650368004.git.wqu@suse.com>
On Tue, Apr 19, 2022 at 07:36:20PM +0800, Qu Wenruo wrote:
> [CHANGELOG]
> v2:
> - Add a test case for it
>
>
> A seed device with dirty log can be rejected by kernel, as kernel will
> try to replay log even on RO mount.
> But log replay on RO device is strongly prohibited, thus such seed
> device will be rejected without a way to sprout.
>
> Fix the problem by letting "btrfstune -S1" to check if the fs has dirty
> log first.
>
> Also add a test case for it, using a btrfs-image dump.
>
> Qu Wenruo (2):
> btrfs-progs: do not allow setting seed flag on fs with dirty log
> btrfs-progs: make sure "btrfstune -S1" will reject fs with dirty log
Added to devel, thanks.
prev parent reply other threads:[~2022-04-25 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 11:36 [PATCH v2 0/2] btrfs-progs: make "btrfstune -S1" to reject fs with dirty log Qu Wenruo
2022-04-19 11:36 ` [PATCH v2 1/2] btrfs-progs: do not allow setting seed flag on " Qu Wenruo
2022-04-19 11:36 ` [PATCH v2 2/2] btrfs-progs: make sure "btrfstune -S1" will reject " Qu Wenruo
2022-04-25 12:11 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425121130.GN18596@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox