From: Pankaj Raghav <p.raghav@samsung.com>
To: jaegeuk@kernel.org, axboe@kernel.dk, snitzer@kernel.org,
hch@lst.de, mcgrof@kernel.org, naohiro.aota@wdc.com,
sagi@grimberg.me, damien.lemoal@opensource.wdc.com,
dsterba@suse.com, johannes.thumshirn@wdc.com
Cc: linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
clm@fb.com, gost.dev@samsung.com, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net, josef@toxicpanda.com,
jonathan.derrick@linux.dev, agk@redhat.com, kbusch@kernel.org,
kch@nvidia.com, linux-nvme@lists.infradead.org,
dm-devel@redhat.com, bvanassche@acm.org,
jiangbo.365@bytedance.com, linux-fsdevel@vger.kernel.org,
matias.bjorling@wdc.com, linux-block@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>
Subject: [PATCH 11/16] btrfs: zoned: relax the alignment constraint for zoned devices
Date: Wed, 27 Apr 2022 18:02:50 +0200 [thread overview]
Message-ID: <20220427160255.300418-12-p.raghav@samsung.com> (raw)
In-Reply-To: <20220427160255.300418-1-p.raghav@samsung.com>
Checks were in place to return error when a non power-of-2 zoned devices
is detected. Remove those checks as non power-of-2 zoned devices are
now supported.
Relax the zone size constraint to align with the BTRFS_STRIPE_LEN(64k)
so that block groups are aligned to the BTRFS_STRIPE_LEN.
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
fs/btrfs/zoned.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 8f3f542e174c..3ed085762f14 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -395,8 +395,7 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device, bool populate_cache)
zone_sectors = bdev_zone_sectors(bdev);
}
- /* Check if it's power of 2 (see is_power_of_2) */
- ASSERT(zone_sectors != 0 && (zone_sectors & (zone_sectors - 1)) == 0);
+ ASSERT(zone_sectors != 0 && IS_ALIGNED(zone_sectors, BTRFS_STRIPE_LEN));
zone_info->zone_size = zone_sectors << SECTOR_SHIFT;
/* We reject devices with a zone size larger than 8GB */
@@ -835,9 +834,11 @@ int btrfs_sb_log_location_bdev(struct block_device *bdev, int mirror, int rw,
ASSERT(rw == READ || rw == WRITE);
- if (!is_power_of_2(bdev_zone_sectors(bdev)))
- return -EINVAL;
nr_sectors = bdev_nr_sectors(bdev);
+
+ if (!IS_ALIGNED(nr_sectors, BTRFS_STRIPE_LEN))
+ return -EINVAL;
+
nr_zones = bdev_zone_no(bdev, nr_sectors);
sb_zone = sb_zone_number(bdev, mirror);
--
2.25.1
next prev parent reply other threads:[~2022-04-27 16:04 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220427160256eucas1p2db2b58792ffc93026d870c260767da14@eucas1p2.samsung.com>
2022-04-27 16:02 ` [PATCH 00/16] support non power of 2 zoned devices Pankaj Raghav
2022-04-27 16:02 ` [PATCH 01/16] block: make blkdev_nr_zones and blk_queue_zone_no generic for npo2 zsze Pankaj Raghav
2022-04-29 17:16 ` Adam Manzanares
2022-05-03 16:37 ` Bart Van Assche
2022-05-03 16:43 ` Damien Le Moal
2022-05-04 8:35 ` Pankaj Raghav
2022-05-04 16:52 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 02/16] block: add blk_queue_zone_aligned and bdev_zone_aligned helper Pankaj Raghav
2022-04-27 23:52 ` Bart Van Assche
2022-05-04 16:55 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 03/16] block: add bdev_zone_no helper Pankaj Raghav
2022-04-27 23:31 ` Damien Le Moal
2022-04-27 23:53 ` Bart Van Assche
2022-05-04 16:55 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 04/16] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-04-27 23:37 ` Damien Le Moal
2022-04-28 17:29 ` Luis Chamberlain
2022-05-04 16:59 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of_2 " Pankaj Raghav
2022-04-29 17:23 ` Adam Manzanares
2022-05-03 16:50 ` Bart Van Assche
2022-05-04 8:38 ` Pankaj Raghav
2022-05-04 17:03 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 06/16] nvmet: use blk_queue_zone_no() Pankaj Raghav
2022-04-29 17:27 ` Adam Manzanares
2022-05-03 16:54 ` Bart Van Assche
2022-05-04 17:05 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 07/16] btrfs: zoned: Cache superblock location in btrfs_zoned_device_info Pankaj Raghav
2022-04-27 16:02 ` [PATCH 08/16] btrfs: zoned: add generic btrfs helpers for zoned devices Pankaj Raghav
2022-04-27 16:02 ` [PATCH 09/16] btrfs: zoned: Make sb_zone_number function non power of 2 compatible Pankaj Raghav
2022-04-27 16:02 ` [PATCH 10/16] btrfs: zoned: use btrfs zone helpers to support non po2 zoned devices Pankaj Raghav
2022-04-27 16:02 ` Pankaj Raghav [this message]
2022-04-27 16:02 ` [PATCH 12/16] zonefs: allow non power of 2 " Pankaj Raghav
2022-04-27 23:39 ` Damien Le Moal
2022-04-27 16:02 ` [PATCH 13/16] null_blk: " Pankaj Raghav
2022-04-29 17:30 ` Adam Manzanares
2022-05-03 17:01 ` Bart Van Assche
2022-05-04 17:10 ` Hannes Reinecke
2022-04-27 16:02 ` [PATCH 14/16] f2fs: call bdev_zone_sectors() only once on init_blkz_info() Pankaj Raghav
2022-05-03 20:04 ` Jaegeuk Kim
2022-04-27 16:02 ` [PATCH 15/16] f2fs: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-05-03 20:05 ` Jaegeuk Kim
2022-05-04 8:53 ` Pankaj Raghav
2022-04-27 16:02 ` [PATCH 16/16] dm-zoned: " Pankaj Raghav
2022-04-27 23:42 ` Damien Le Moal
2022-04-28 17:34 ` Luis Chamberlain
2022-04-28 21:43 ` Damien Le Moal
2022-04-28 22:06 ` Luis Chamberlain
2022-05-04 17:11 ` Hannes Reinecke
2022-05-02 22:07 ` [PATCH 00/16] support non power of 2 zoned devices Johannes Thumshirn
2022-05-03 9:12 ` Pankaj Raghav
2022-05-04 21:14 ` David Sterba
2022-05-05 7:28 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427160255.300418-12-p.raghav@samsung.com \
--to=p.raghav@samsung.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=jiangbo.365@bytedance.com \
--cc=johannes.thumshirn@wdc.com \
--cc=jonathan.derrick@linux.dev \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=matias.bjorling@wdc.com \
--cc=mcgrof@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=sagi@grimberg.me \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox