Re: [PATCH 0/9] Structre and parameter cleanups

David Sterba
2022-05-09T20:00:39Z

On Tue, May 03, 2022 at 10:57:19AM +0300, Nikolay Borisov wrote:
>
>
> On 29.04.22 г. 21:27 ч., David Sterba wrote:
> > Simplify some argument passing, remove too-trivial helpers or unused
> > structure members.
> >
> > David Sterba (9):
> > btrfs: sink parameter is_data to btrfs_set_disk_extent_flags
> > btrfs: remove btrfs_delayed_extent_op::is_data
> > btrfs: remove unused parameter bio_flags from btrfs_wq_submit_bio
> > btrfs: remove trivial helper update_nr_written
> > btrfs: simplify handling of bio_ctrl::bio_flags
> > btrfs: open code extent_set_compress_type helpers
> > btrfs: rename io_failure_record::bio_flags to compress_type
> > btrfs: rename bio_flags in parameters and switch type
> > btrfs: rename bio_ctrl::bio_flags to compress_type
> >
> > fs/btrfs/ctree.c | 2 +-
> > fs/btrfs/ctree.h | 5 ++-
> > fs/btrfs/delayed-ref.c | 4 +--
> > fs/btrfs/delayed-ref.h | 1 -
> > fs/btrfs/disk-io.c | 5 ++-
> > fs/btrfs/disk-io.h | 3 +-
> > fs/btrfs/extent-tree.c | 10 +++---
> > fs/btrfs/extent_io.c | 73 ++++++++++++++++++------------------------
> > fs/btrfs/extent_io.h | 22 ++-----------
> > fs/btrfs/inode.c | 10 +++---
> > 10 files changed, 50 insertions(+), 85 deletions(-)
> >
>
>
> FWIW:
>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
>
> (I did look at the patches that have been merged into misc-next with the
> compression type fixed up) .

Thanks, commits updated.