Re: [PATCH 7/9] btrfs: rename io_failure_record::bio_flags to compress_type

Johannes Thumshirn
2022-05-02T16:32:25Z

On 02/05/2022 09:30, David Sterba wrote:
> On Mon, May 02, 2022 at 05:16:59PM +0200, David Sterba wrote:
>> On Sun, May 01, 2022 at 08:22:41PM +0000, Johannes Thumshirn wrote:
>>> On 29/04/2022 11:32, David Sterba wrote:
>>>> diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h
>>>> index fdbfe801dbe2..1fa40ab561df 100644
>>>> --- a/fs/btrfs/extent_io.h
>>>> +++ b/fs/btrfs/extent_io.h
>>>> @@ -266,7 +266,7 @@ struct io_failure_record {
>>>> u64 start;
>>>> u64 len;
>>>> u64 logical;
>>>> - unsigned long bio_flags;
>>>> + unsigned int compress_type;
>>>> int this_mirror;
>>>> int failed_mirror;
>>>> };
>>>
>>>
>>> Why 'unsigned int' and not 'enum btrfs_compression_type'?
>>
>> Good point I'll change it, though it's not used almost anywhere else.
>
> I'll fix up the 2 following patches as well, the type switch in parameters.
>

Cool thanks, I was about to ask.