Re: [PATCH] btrfs: Fix an error handling path in btrfs_read_sys_array()

David Sterba
2022-05-16T15:06:31Z

On Mon, May 16, 2022 at 04:54:07PM +0300, Dan Carpenter wrote:
> On Sun, May 15, 2022 at 06:57:25AM +0800, Qu Wenruo wrote:
> >
> >
> > On 2022/5/14 20:01, Christophe JAILLET wrote:
> > > If alloc_dummy_extent_buffer() we should return an error code, not 0 that
> > > would mean success.
> > >
> > > Fixes: a1fc41ac28d3 ("btrfs: use dummy extent buffer for super block sys chunk array read")
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> >
> > Reviewed-by: Qu Wenruo <wqu@suse.com>
> >
> > All my fault, thanks for catching it.
> > Qu
> >
>
> I sent this patch in January and David was going to fold it into the
> original patch but it got lost. Thanks, Christophe!

I found my reply to your fix that I folded the fixup, but then it got
lost for some reason. Probably because I picked the patchset from
mailing list again and did not take the local branch. I'll fold the fix
again as it' still in the unmerged branch. Thanks.