Re: [PATCH v4 06/13] btrfs: zoned: Make sb_zone_number function non power of 2 compatible

David Sterba
2022-05-17T11:55:52Z

On Tue, May 17, 2022 at 06:53:40AM +0000, Johannes Thumshirn wrote:
> On 16/05/2022 18:54, Pankaj Raghav wrote:
> > /* Cache the sb zone number */
> > for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; ++i) {
> > zone_info->sb_zone_location[i] =
> > - sb_zone_number(zone_info->zone_size_shift, i);
> > + sb_zone_number(bdev, i);
>
> I think this easily fits on one line now, doesn't it? But given David's
> statement, it'll probably can go away anyways.

I agree that the formatting can be adjusted, but I'm never sure if I
should point it out during the phase of functional changes so it's fixed
in the next iteration as well, or not to point it out to avoid fixups
that would go away anyway. I think I've seen more, a styling pass will
be done anyway once we're close to the final version..