From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/2] btrfs: teach send to avoid trashing the page cache with data
Date: Tue, 17 May 2022 20:18:17 +0200 [thread overview]
Message-ID: <20220517181817.GE18596@twin.jikos.cz> (raw)
In-Reply-To: <cover.1652784088.git.fdmanana@suse.com>
On Tue, May 17, 2022 at 11:47:28AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> When doing a send operation, we read the data of all extents we need to
> send into the page cache, which almost always is wasteful as it can lead
> to eviction of other things from the page cache that are more useful for
> applications (and maybe other kernel subsystems). This patchset makes send
> evict the data from the page cache once it has sent it. The actual work
> is in the second patch, while the first one is just preparatory work.
> More details in the changelogs.
>
> V2: Fixed it to work with subpage sector size. It was broken as we could
> end up zeroing out part of a page when extents are not sector size
> aligned. Reported by Qu.
>
> Filipe Manana (2):
> btrfs: send: keep the current inode open while processing it
> btrfs: send: avoid trashing the page cache
Patch 1 is the same so I kept the committed version and 2 has been
replaced, still queued for first 5.19 pull as it's fixing a problem
that hampers testing. Thanks.
prev parent reply other threads:[~2022-05-17 18:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 17:16 [PATCH 0/2] btrfs: teach send to avoid trashing the page cache with data fdmanana
2022-05-05 17:16 ` [PATCH 1/2] btrfs: send: keep the current inode open while processing it fdmanana
2022-05-05 17:16 ` [PATCH 2/2] btrfs: send: avoid trashing the page cache fdmanana
2022-05-17 6:35 ` Qu Wenruo
2022-05-17 7:26 ` Qu Wenruo
2022-05-17 9:39 ` Filipe Manana
2022-05-17 10:36 ` Qu Wenruo
2022-05-17 10:46 ` Filipe Manana
2022-05-09 19:08 ` [PATCH 0/2] btrfs: teach send to avoid trashing the page cache with data David Sterba
2022-05-17 10:47 ` [PATCH v2 " fdmanana
2022-05-17 10:47 ` [PATCH 1/2] btrfs: send: keep the current inode open while processing it fdmanana
2022-05-17 10:47 ` [PATCH 2/2] btrfs: send: avoid trashing the page cache fdmanana
2022-05-17 18:18 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517181817.GE18596@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox