From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 09/15] btrfs: factor out a btrfs_csum_ptr helper
Date: Wed, 18 May 2022 10:45:29 +0200 [thread overview]
Message-ID: <20220518084529.GC6933@lst.de> (raw)
In-Reply-To: <PH0PR04MB74165799E9088993A3DC984C9BCE9@PH0PR04MB7416.namprd04.prod.outlook.com>
On Tue, May 17, 2022 at 03:24:26PM +0000, Johannes Thumshirn wrote:
> On 17/05/2022 16:52, Christoph Hellwig wrote:
> > +static inline u8 *btrfs_csum_ptr(struct btrfs_fs_info *fs_info, u8 *csums,
> > + u64 offset)
> > +{
> > + return csums +
> > + ((offset >> fs_info->sectorsize_bits) * fs_info->csum_size);
>
> I guess a local variable for holding 'offset >> fs_info->sectorsize_bits'
> wouldn't have hurt readability and the compiler would've optimized it away,
> but that's just me nitpicking.
I can do that if there is a strong opinion, but I'm not sure it would
help readability at all.
next prev parent reply other threads:[~2022-05-18 8:45 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 14:50 simple synchronous read repair Christoph Hellwig
2022-05-17 14:50 ` [PATCH 01/15] btrfs: introduce a pure data checksum checking helper Christoph Hellwig
2022-05-17 14:59 ` Johannes Thumshirn
2022-05-18 8:44 ` Christoph Hellwig
2022-05-20 8:45 ` Nikolay Borisov
2022-05-20 16:24 ` Christoph Hellwig
2022-05-17 14:50 ` [PATCH 02/15] btrfs: quit early if the fs has no RAID56 support for raid56 related checks Christoph Hellwig
2022-05-17 15:00 ` Johannes Thumshirn
2022-05-18 17:07 ` Anand Jain
2022-05-20 8:47 ` Nikolay Borisov
2022-05-20 16:25 ` Christoph Hellwig
2022-05-20 22:36 ` Qu Wenruo
2022-05-17 14:50 ` [PATCH 03/15] btrfs: save the original bi_iter into btrfs_bio for buffered read Christoph Hellwig
2022-05-17 14:50 ` [PATCH 04/15] btrfs: remove duplicated parameters from submit_data_read_repair() Christoph Hellwig
2022-05-17 15:35 ` Johannes Thumshirn
2022-05-20 10:05 ` Nikolay Borisov
2022-05-17 14:50 ` [PATCH 05/15] btrfs: add a helper to iterate through a btrfs_bio with sector sized chunks Christoph Hellwig
2022-05-17 15:27 ` Johannes Thumshirn
2022-05-18 8:46 ` Christoph Hellwig
2022-05-18 10:07 ` Qu Wenruo
2022-05-20 16:27 ` Christoph Hellwig
2022-05-21 1:16 ` Qu Wenruo
2022-05-17 14:50 ` [PATCH 06/15] btrfs: make repair_io_failure available outside of extent_io.c Christoph Hellwig
2022-05-17 15:18 ` Johannes Thumshirn
2022-05-17 14:50 ` [PATCH 07/15] btrfs: factor out a helper to end a single sector from submit_data_read_repair Christoph Hellwig
2022-05-17 15:18 ` Johannes Thumshirn
2022-05-17 22:17 ` Qu Wenruo
2022-05-17 14:50 ` [PATCH 08/15] btrfs: refactor end_bio_extent_readpage Christoph Hellwig
2022-05-17 22:22 ` Qu Wenruo
2022-05-18 8:48 ` Christoph Hellwig
2022-05-17 14:50 ` [PATCH 09/15] btrfs: factor out a btrfs_csum_ptr helper Christoph Hellwig
2022-05-17 15:24 ` Johannes Thumshirn
2022-05-18 8:45 ` Christoph Hellwig [this message]
2022-05-17 14:50 ` [PATCH 10/15] btrfs: add a btrfs_map_bio_wait helper Christoph Hellwig
2022-05-17 15:37 ` Johannes Thumshirn
2022-05-17 22:26 ` Qu Wenruo
2022-05-18 8:47 ` Christoph Hellwig
2022-05-17 14:50 ` [PATCH 11/15] btrfs: set ->file_offset in end_bio_extent_readpage Christoph Hellwig
2022-05-17 22:47 ` Qu Wenruo
2022-05-17 14:50 ` [PATCH 12/15] btrfs: add new read repair infrastructure Christoph Hellwig
2022-05-17 23:04 ` Qu Wenruo
2022-05-18 8:54 ` Christoph Hellwig
2022-05-18 10:20 ` Qu Wenruo
2022-05-18 12:48 ` Christoph Hellwig
2022-05-19 9:36 ` Christoph Hellwig
2022-05-19 10:41 ` Qu Wenruo
2022-05-19 10:45 ` Nikolay Borisov
2022-05-19 10:46 ` Qu Wenruo
2022-05-19 10:50 ` Christoph Hellwig
2022-05-19 11:27 ` Qu Wenruo
2022-05-20 6:43 ` Why btrfs no longer allocate the extent at the beginning of an empty chunk (was: Re: [PATCH 12/15] btrfs: add new read repair infrastructure) Qu Wenruo
2022-05-20 15:25 ` [PATCH 12/15] btrfs: add new read repair infrastructure Christoph Hellwig
2022-05-17 14:50 ` [PATCH 13/15] btrfs: use the new read repair code for direct I/O Christoph Hellwig
2022-05-17 14:50 ` [PATCH 14/15] btrfs: use the new read repair code for buffered reads Christoph Hellwig
2022-05-17 14:50 ` [PATCH 15/15] btrfs: remove io_failure_record infrastructure completely Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518084529.GC6933@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox