From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224CEC433EF for ; Sun, 22 May 2022 12:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345407AbiEVMxp (ORCPT ); Sun, 22 May 2022 08:53:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345405AbiEVMxm (ORCPT ); Sun, 22 May 2022 08:53:42 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F40A245B2 for ; Sun, 22 May 2022 05:53:41 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4297668AFE; Sun, 22 May 2022 14:53:38 +0200 (CEST) Date: Sun, 22 May 2022 14:53:37 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 8/8] btrfs: use btrfs_bio_for_each_sector in btrfs_check_read_dio_bio Message-ID: <20220522125337.GB24032@lst.de> References: <20220522114754.173685-1-hch@lst.de> <20220522114754.173685-9-hch@lst.de> <20220522123108.GA23355@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, May 22, 2022 at 08:38:50PM +0800, Qu Wenruo wrote: >> 'cause now a lot of the bio works will depend on the read repair, and >> I don't want to block it on yet another series.. > > Although I believe we will have to take more time on the read repair > code/functionality. > > Especially all our submitted version have their own problems. > > From the basic handling of checker pattern corruption, to the trade-off > between memory allocation and performance for read on corrupted data. I've already pushed out a new version here: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/btrfs-read_repair so feel free to take a look. I just don't want to spam the list with it quite yet with this series outstanding.