From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D116FC433EF for ; Wed, 1 Jun 2022 20:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbiFAUpq (ORCPT ); Wed, 1 Jun 2022 16:45:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbiFAUpW (ORCPT ); Wed, 1 Jun 2022 16:45:22 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B6DC262AC2 for ; Wed, 1 Jun 2022 13:32:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 45E3821AFB; Wed, 1 Jun 2022 19:37:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1654112223; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO5axQo11rV/BU8R41QEiZA2L+7587OTT+SEsS0LpYA=; b=Rnj3epdxT0G017l3wqVvdckGeDToV/cnqseFiWL4juJriUOfhB9S9fg82lEvDYDwc+CLWV KX/Yodtklv7ziShQrWSe2/OBThq5IXcBj/8MyD1PmET+SorFDe8B9hCzk66DbynjwkjwXR 6e0chsJe50/irNfPD84fLK2dGEE74Nk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1654112223; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO5axQo11rV/BU8R41QEiZA2L+7587OTT+SEsS0LpYA=; b=w3U0QyN3HSa0eE0FNIVe1abrfUTyYkDP63KQPkwK8rRjuzzM00j1kTZ1EGUb51oABj7gPT oSBNkZX/0xCxNgBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1997D1330F; Wed, 1 Jun 2022 19:37:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p8JVBd+/l2IQFgAAMHmgww (envelope-from ); Wed, 01 Jun 2022 19:37:03 +0000 Date: Wed, 1 Jun 2022 21:32:36 +0200 From: David Sterba To: Christoph Hellwig Cc: David Sterba , Josef Bacik , Qu Wenruo , linux-btrfs@vger.kernel.org, Johannes Thumshirn Subject: Re: [PATCH 02/10] btrfs: cleanup btrfs_submit_dio_bio Message-ID: <20220601193236.GR20633@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig , David Sterba , Josef Bacik , Qu Wenruo , linux-btrfs@vger.kernel.org, Johannes Thumshirn References: <20220526073642.1773373-1-hch@lst.de> <20220526073642.1773373-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526073642.1773373-3-hch@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, May 26, 2022 at 09:36:34AM +0200, Christoph Hellwig wrote: > Remove the pointless goto just to return err and clean up the code flow > to be a little more straight forward. Please use more descriptive subjects, "cleaup function" is too generic and makes navigation in patches harder. The changelog text usually gives hint what exactly is being cleaned up, in this case it's code flow so I've used subject "simplify code flow in btrfs_submit_dio_bio".