From: Filipe Manana <fdmanana@kernel.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs/220: zoned: skip nodatacow mount option for zoned btrfs
Date: Tue, 7 Jun 2022 11:03:44 +0100 [thread overview]
Message-ID: <20220607100344.GA3556776@falcondesktop> (raw)
In-Reply-To: <20220607080635.4010254-1-naohiro.aota@wdc.com>
On Tue, Jun 07, 2022 at 05:06:35PM +0900, Naohiro Aota wrote:
> The nodatacow mount option is not allowed on zoned btrfs and failing the
> test. Skip the cases for zoned btrfs.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Looks good, thanks.
> ---
> tests/btrfs/220 | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/tests/btrfs/220 b/tests/btrfs/220
> index fa91a38493af..4d94ccd6eee2 100755
> --- a/tests/btrfs/220
> +++ b/tests/btrfs/220
> @@ -265,14 +265,16 @@ test_revertible_options()
> test_roundtrip_mount "compress=zlib:20" "compress=zlib:9" "compress=zstd:16" "compress=zstd:15"
> test_roundtrip_mount "compress-force=lzo" "compress-force=lzo" "compress-force=zlib:4" "compress-force=zlib:4"
>
> - # on remount, if we only pass datacow after nodatacow was used it will remain with nodatasum
> - test_roundtrip_mount "nodatacow" "nodatasum,nodatacow" "datacow,datasum" "$DEFAULT_OPTS"
> - # nodatacow disabled compression
> - test_roundtrip_mount "compress-force" "compress-force=zlib:3" "nodatacow" "nodatasum,nodatacow"
> -
> - # nodatacow disabled both datacow and datasum, and datasum enabled datacow and datasum
> - test_roundtrip_mount "nodatacow" "nodatasum,nodatacow" "datasum" "$DEFAULT_OPTS"
> - test_roundtrip_mount "nodatasum" "nodatasum" "datasum" "$DEFAULT_OPTS"
> + if ! _scratch_btrfs_is_zoned; then
> + # on remount, if we only pass datacow after nodatacow was used it will remain with nodatasum
> + test_roundtrip_mount "nodatacow" "nodatasum,nodatacow" "datacow,datasum" "$DEFAULT_OPTS"
> + # nodatacow disabled compression
> + test_roundtrip_mount "compress-force" "compress-force=zlib:3" "nodatacow" "nodatasum,nodatacow"
> +
> + # nodatacow disabled both datacow and datasum, and datasum enabled datacow and datasum
> + test_roundtrip_mount "nodatacow" "nodatasum,nodatacow" "datasum" "$DEFAULT_OPTS"
> + test_roundtrip_mount "nodatasum" "nodatasum" "datasum" "$DEFAULT_OPTS"
> + fi
>
> test_should_fail "discard=invalid"
> if [ "$enable_discard_sync" = true ]; then
> --
> 2.35.1
>
prev parent reply other threads:[~2022-06-07 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 8:06 [PATCH] btrfs/220: zoned: skip nodatacow mount option for zoned btrfs Naohiro Aota
2022-06-07 10:03 ` Filipe Manana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607100344.GA3556776@falcondesktop \
--to=fdmanana@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox