From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-btrfs-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A121CC433EF
	for <linux-btrfs@archiver.kernel.org>; Sun, 19 Jun 2022 06:35:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229962AbiFSGfv (ORCPT <rfc822;linux-btrfs@archiver.kernel.org>);
        Sun, 19 Jun 2022 02:35:51 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53140 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229673AbiFSGfu (ORCPT
        <rfc822;linux-btrfs@vger.kernel.org>);
        Sun, 19 Jun 2022 02:35:50 -0400
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E128389A
        for <linux-btrfs@vger.kernel.org>; Sat, 18 Jun 2022 23:35:49 -0700 (PDT)
Received: by verein.lst.de (Postfix, from userid 2407)
        id A48A168AA6; Sun, 19 Jun 2022 08:35:45 +0200 (CEST)
Date:   Sun, 19 Jun 2022 08:35:45 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc:     Christoph Hellwig <hch@lst.de>, David Sterba <dsterba@suse.com>,
        Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 05/10] btrfs: remove the raid56_parity_recover return
 value
Message-ID: <20220619063545.GA27154@lst.de>
References: <20220617100414.1159680-1-hch@lst.de> <20220617100414.1159680-6-hch@lst.de> <PH0PR04MB74162BBB070D56528215E6569BAE9@PH0PR04MB7416.namprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH0PR04MB74162BBB070D56528215E6569BAE9@PH0PR04MB7416.namprd04.prod.outlook.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-btrfs.vger.kernel.org>
X-Mailing-List: linux-btrfs@vger.kernel.org

On Sat, Jun 18, 2022 at 11:06:06AM +0000, Johannes Thumshirn wrote:
> On 17.06.22 12:04, Christoph Hellwig wrote:
> > -	ret = lock_stripe_add(rbio);
> > +	if (lock_stripe_add(rbio))
> > +		return;
> >  
> 
> I kinda have the feeling lock_stripe_add() should return bool,
> but that's out of scope for this patch.

Yes, it should.  But it does not fit this patch, and even the series
seems big enough already as-is..