From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 10/10] btrfs: remove bioc->stripes_pending
Date: Wed, 22 Jun 2022 18:15:46 +0200 [thread overview]
Message-ID: <20220622161546.GA683@lst.de> (raw)
In-Reply-To: <20220622160725.GJ20633@twin.jikos.cz>
On Wed, Jun 22, 2022 at 06:07:25PM +0200, David Sterba wrote:
> On Fri, Jun 17, 2022 at 12:04:14PM +0200, Christoph Hellwig wrote:
> > Replace the stripes_pending field with the pending counter in the bio.
> > This avoid an extra field and prepares splitting the btrfs_bio at the
> > stripe boundary.
>
> This does not seem sufficient as changelog, does not explain why the
> stripes_pending is being removed, just that it's some prep work. Given
> the questions that Nikolay had I think this needs to be expanded. I'll
> try to summarize the discussion but in the bio code nothing is that
> simple that reading the patch would answer all questions.
Maybe just skip this patch for now then. I also have two follows up
for it, so I can resend it with an updated version of this one.
But the single sentence summary is: use the block layer infrastructure
instead of reinveting it poorly.
next prev parent reply other threads:[~2022-06-22 16:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 10:04 cleanup btrfs bio submission v2 Christoph Hellwig
2022-06-17 10:04 ` [PATCH 01/10] btrfs: remove a bunch of pointles stripe_len arguments Christoph Hellwig
2022-06-20 17:16 ` David Sterba
2022-06-20 17:38 ` Christoph Hellwig
2022-06-22 4:19 ` Christoph Hellwig
2022-06-22 14:07 ` David Sterba
2022-06-22 4:30 ` Qu Wenruo
2022-06-17 10:04 ` [PATCH 02/10] btrfs: return proper mapped length for RAID56 profiles in __btrfs_map_block() Christoph Hellwig
2022-06-17 10:04 ` [PATCH 03/10] btrfs: remove the btrfs_map_bio return value Christoph Hellwig
2022-06-17 10:04 ` [PATCH 04/10] btrfs: remove the raid56_parity_write " Christoph Hellwig
2022-06-17 10:38 ` Qu Wenruo
2022-06-18 11:04 ` Johannes Thumshirn
2022-06-17 10:04 ` [PATCH 05/10] btrfs: remove the raid56_parity_recover " Christoph Hellwig
2022-06-18 11:06 ` Johannes Thumshirn
2022-06-19 6:35 ` Christoph Hellwig
2022-06-19 10:35 ` Qu Wenruo
2022-06-17 10:04 ` [PATCH 06/10] btrfs: transfer the bio counter reference to the raid submission helpers Christoph Hellwig
2022-06-19 10:45 ` Qu Wenruo
2022-06-19 21:50 ` Qu Wenruo
2022-06-20 7:47 ` Christoph Hellwig
2022-06-20 8:03 ` Qu Wenruo
2022-06-20 8:09 ` Christoph Hellwig
2022-06-20 7:37 ` Christoph Hellwig
2022-06-20 7:45 ` Qu Wenruo
2022-06-20 7:49 ` Christoph Hellwig
2022-06-17 10:04 ` [PATCH 07/10] btrfs: simplify the reloc root check in btrfs_submit_data_write_bio Christoph Hellwig
2022-06-17 10:04 ` [PATCH 08/10] btrfs: handle allocation failure in btrfs_wq_submit_bio gracefully Christoph Hellwig
2022-06-28 15:20 ` Boris Burkov
2022-06-17 10:04 ` [PATCH 09/10] btrfs: remove the btrfs_submit_dio_bio return value Christoph Hellwig
2022-06-17 10:04 ` [PATCH 10/10] btrfs: remove bioc->stripes_pending Christoph Hellwig
2022-06-20 8:18 ` Nikolay Borisov
2022-06-20 8:34 ` Nikolay Borisov
2022-06-20 8:53 ` Christoph Hellwig
2022-06-20 9:34 ` Nikolay Borisov
2022-06-20 11:23 ` Christoph Hellwig
2022-06-22 16:07 ` David Sterba
2022-06-22 16:15 ` Christoph Hellwig [this message]
2022-07-07 18:34 ` David Sterba
2022-06-20 13:04 ` cleanup btrfs bio submission v2 Nikolay Borisov
2022-07-07 18:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220622161546.GA683@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox