From: Christoph Hellwig <hch@lst.de>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 7/7] btrfs: stop allocation a btrfs_io_context for simple I/O
Date: Tue, 12 Jul 2022 11:31:55 +0200 [thread overview]
Message-ID: <20220712093155.GA16647@lst.de> (raw)
In-Reply-To: <d5bffdd9-1ed5-89db-18c1-2bcccb9f537c@suse.com>
On Tue, Jul 12, 2022 at 12:28:14PM +0300, Nikolay Borisov wrote:
> This patch IMO needs to be split:
>
> 1. Make a patch which introduces the various split endio functions.
Where "the various split endio functions" is btrfs_simple_end_io?
btrfs_simple_end_io relies on the fact that it doesn't need to deal
with and a free a btrfs_io_context, so without:
> 2. Then do the cleanups around __btrfs_map_block group and how submitted
> bios are being initialized and processed in btrfs_submit_bio et al.
the only thing I could do is to first allocate an btrfs_io_context and
just free it directly after I/O submission. Which sounds doable if
we really want to split it for splitting's sake, but it probably
hurts understanding the concept instead of helping that.
next prev parent reply other threads:[~2022-07-12 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 8:43 btrfs I/O completion cleanup and single device I/O optimizations Christoph Hellwig
2022-07-04 8:44 ` [PATCH 1/7] btrfs: don't call bioset_integrity_create for btrfs_bioset Christoph Hellwig
2022-07-06 6:48 ` Johannes Thumshirn
2022-07-04 8:44 ` [PATCH 2/7] btrfs: move btrfs_bio allocation to volumes.c Christoph Hellwig
2022-07-06 7:03 ` Johannes Thumshirn
2022-07-04 8:44 ` [PATCH 3/7] btrfs: pass the operation to btrfs_bio_alloc Christoph Hellwig
2022-07-06 6:48 ` Johannes Thumshirn
2022-07-04 8:44 ` [PATCH 4/7] btrfs: properly abstract the parity raid bio handling Christoph Hellwig
2022-07-06 7:07 ` Johannes Thumshirn
2022-07-04 8:44 ` [PATCH 5/7] btrfs: give struct btrfs_bio a real end_io handler Christoph Hellwig
2022-07-04 8:44 ` [PATCH 6/7] btrfs: split out the end_io handler for cloned bios Christoph Hellwig
2022-07-06 6:49 ` Johannes Thumshirn
2022-07-04 8:44 ` [PATCH 7/7] btrfs: stop allocation a btrfs_io_context for simple I/O Christoph Hellwig
2022-07-06 17:07 ` Johannes Thumshirn
2022-07-12 9:28 ` Nikolay Borisov
2022-07-12 9:31 ` Christoph Hellwig [this message]
2022-07-07 12:20 ` btrfs I/O completion cleanup and single device I/O optimizations Johannes Thumshirn
2022-07-12 14:22 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712093155.GA16647@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox