Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz, Christoph Hellwig <hch@lst.de>,
	clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
	naohiro.aota@wdc.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: align max_zone_append_size to the sector size
Date: Mon, 18 Jul 2022 10:11:27 +0200	[thread overview]
Message-ID: <20220718081127.GA29070@lst.de> (raw)
In-Reply-To: <20220714125247.GJ15169@twin.jikos.cz>

On Thu, Jul 14, 2022 at 02:52:47PM +0200, David Sterba wrote:
> > Fixes: 385ea2aea011 ("btrfs: replace BTRFS_MAX_EXTENT_SIZE with fs_info->max_extent_size")
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Folded to the patch, thanks.

Turns out this is still broken as I was misled by the fancy ALIGN
macro.  We need the incremental change below.  Do you want to fold
this in again or should I sent it as a separate patch:


diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 606cd4aab3902..fb335e87b2212 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -740,7 +740,7 @@ int btrfs_check_zoned_mode(struct btrfs_fs_info *fs_info)
 
 	fs_info->zone_size = zone_size;
 	fs_info->max_zone_append_size =
-		ALIGN(max_zone_append_size, fs_info->sectorsize);
+		ALIGN_DOWN(max_zone_append_size, fs_info->sectorsize);
 	fs_info->fs_devices->chunk_alloc_policy = BTRFS_CHUNK_ALLOC_ZONED;
 	if (fs_info->max_zone_append_size < fs_info->max_extent_size)
 		fs_info->max_extent_size = fs_info->max_zone_append_size;

  reply	other threads:[~2022-07-18  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  9:16 [PATCH] btrfs: align max_zone_append_size to the sector size Christoph Hellwig
2022-07-14  9:21 ` Johannes Thumshirn
2022-07-14 12:52 ` David Sterba
2022-07-18  8:11   ` Christoph Hellwig [this message]
2022-07-18 14:31     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718081127.GA29070@lst.de \
    --to=hch@lst.de \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox