Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Naohiro Aota <naohiro.aota@wdc.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: error writing primary super block on zoned btrfs
Date: Mon, 18 Jul 2022 14:33:04 +0200	[thread overview]
Message-ID: <20220718123304.GA15340@lst.de> (raw)
In-Reply-To: <YtVSBLTuRCED9mYb@casper.infradead.org>

On Mon, Jul 18, 2022 at 01:28:52PM +0100, Matthew Wilcox wrote:
> A "value" entry in the block device's i_pages will be a shadow entry --
> that is, the page has reached the end of the LRU list and been discarded,
> so we made a note that we would have liked to keep it in the LRU list,
> but we didn't have enough memory in the system to do so.  That helps
> us put it back in the right position in the LRU list when it gets
> brought back in from disc.
> 
> I'd sugegst something else has gone wrong, maybe the refcount should
> have been kept elevated to prevent the superblock from being paged out.
> I find it hard to believe that we can be so low on memory that we need
> to page out a superblock to make room for some other memory allocation.
> 
> (Although maybe if you have millions of unusued filesystems mounted ...?)

This is a freshly booted VM running the test on the only non-root
disk file system.  So yeah, there must be a logic error somewhere
in the use of the page cache.

  reply	other threads:[~2022-07-18 12:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  5:49 error writing primary super block on zoned btrfs Christoph Hellwig
2022-07-18 12:28 ` Matthew Wilcox
2022-07-18 12:33   ` Christoph Hellwig [this message]
2022-07-19  7:53   ` Johannes Thumshirn
2022-07-19 15:13     ` Christoph Hellwig
2022-07-19 21:32       ` David Sterba
2022-07-25 17:36         ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718123304.GA15340@lst.de \
    --to=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox