Re: [PATCH] btrfs-progs: make btrfs_super_block::log_root_transid deprecated

[David Sterba <dsterba@suse.cz>]

On Tue, Jul 19, 2022 at 09:31:28AM +0800, Qu Wenruo wrote:
> 
> 
> On 2022/7/18 23:34, David Sterba wrote:
> > On Tue, Jun 07, 2022 at 08:01:17PM +0800, Qu Wenruo wrote:
> >> This is the same on-disk format update synchronized from the kernel
> >> code.
> >>
> >> Unlike kernel, there are two callers reading this member:
> >>
> >> - btrfs inspect dump-super
> >>    It's just outputting the value, since it's always 0 we can skip
> >>    that output.
> >>
> >> - btrfs-find-root
> >>    In that case, since we always got 0, the root search for log root
> >>    should never find a perfect match.
> >>
> >>    Use btrfs_super_geneartion() + 1 to provide a better result.
> >>
> >> Signed-off-by: Qu Wenruo <wqu@suse.com>
> > 
> > Added to devel, thanks.
> > 
> >> --- a/kernel-shared/print-tree.c
> >> +++ b/kernel-shared/print-tree.c
> >> @@ -2014,8 +2014,6 @@ void btrfs_print_superblock(struct btrfs_super_block *sb, int full)
> >>   	       (unsigned long long)btrfs_super_chunk_root_level(sb));
> >>   	printf("log_root\t\t%llu\n",
> >>   	       (unsigned long long)btrfs_super_log_root(sb));
> >> -	printf("log_root_transid\t%llu\n",
> >> -	       (unsigned long long)btrfs_super_log_root_transid(sb));
> > 
> > For dump super I'd like to keep it there, same as we print the value of
> > leafsize even if it's deprecated.
> 
> In that case, we only need add "(deprecated)" to the string and adjust 
> the offset.
> 
> Do I need to update the patch or send a incremental update?

No need to, it was a simple fixup.