From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770C2C25B08 for ; Sat, 13 Aug 2022 06:19:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235029AbiHMGTI (ORCPT ); Sat, 13 Aug 2022 02:19:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbiHMGTH (ORCPT ); Sat, 13 Aug 2022 02:19:07 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8866D8284D for ; Fri, 12 Aug 2022 23:19:06 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 113A168AA6; Sat, 13 Aug 2022 08:19:02 +0200 (CEST) Date: Sat, 13 Aug 2022 08:19:01 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, Zygo Blaxell , Christoph Hellwig Subject: Re: [PATCH] Revert "btrfs: fix repair of compressed extents" and "btrfs: pass a btrfs_bio to btrfs_repair_one_sector" Message-ID: <20220813061901.GA10401@lst.de> References: <09b666a5e355472749a243946a9199ce2d6cef77.1660370422.git.wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09b666a5e355472749a243946a9199ce2d6cef77.1660370422.git.wqu@suse.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Aug 13, 2022 at 02:00:25PM +0800, Qu Wenruo wrote: > To fix the problem, we need to revert commit 7aa51232e204 ("btrfs: pass > a btrfs_bio to btrfs_repair_one_sector"), but unfortunately later commit > 81bd9328ab9f ("btrfs: fix repair of compressed extents") has a > dependency on that commit. Let's try to sort this out properly intead of doing a blind revert before -rc1. I'll cook up a patch to pass an explicit offset ASAP as the quick fix, but for the longer run: is there such a huge benefit of having these logically non-contigous bios? They are so different from the I/O stack in any other file systems that I think we'll keep running into problems again an again.