From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3705C25B08 for ; Sat, 13 Aug 2022 06:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234527AbiHMG6i (ORCPT ); Sat, 13 Aug 2022 02:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbiHMG6i (ORCPT ); Sat, 13 Aug 2022 02:58:38 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F5025EB7 for ; Fri, 12 Aug 2022 23:58:37 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C709668AA6; Sat, 13 Aug 2022 08:58:33 +0200 (CEST) Date: Sat, 13 Aug 2022 08:58:33 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org, Zygo Blaxell Subject: Re: [PATCH] Revert "btrfs: fix repair of compressed extents" and "btrfs: pass a btrfs_bio to btrfs_repair_one_sector" Message-ID: <20220813065833.GA11075@lst.de> References: <09b666a5e355472749a243946a9199ce2d6cef77.1660370422.git.wqu@suse.com> <20220813061901.GA10401@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Aug 13, 2022 at 02:53:09PM +0800, Qu Wenruo wrote: > But indeed, if we allow that, it would be a much simpler fix. > > Mind me to introduce a patch to add a new page offset contingous check > to the related code path? I had just started on passing the arguments again, but I'll switch to this version. It should be simpler, and will also allow to remove quite a bit code related to this case later on.