From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FAEC25B08 for ; Sat, 13 Aug 2022 07:46:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233812AbiHMHqR (ORCPT ); Sat, 13 Aug 2022 03:46:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbiHMHqP (ORCPT ); Sat, 13 Aug 2022 03:46:15 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0BFBCB4 for ; Sat, 13 Aug 2022 00:46:14 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 7CD9168AA6; Sat, 13 Aug 2022 09:46:11 +0200 (CEST) Date: Sat, 13 Aug 2022 09:46:11 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org, Zygo Blaxell Subject: Re: [PATCH] btrfs: don't merge pages into bio if their page offset is not continuous Message-ID: <20220813074611.GA11755@lst.de> References: <8641e5e791942d86de0a1b3ee120570441616fdc.1660375698.git.wqu@suse.com> <20220813073909.GA11586@lst.de> <1f71de8a-2292-054e-913b-15e41b409de6@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f71de8a-2292-054e-913b-15e41b409de6@gmx.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Aug 13, 2022 at 03:43:49PM +0800, Qu Wenruo wrote: > BTW, I'll also update the commit message to mention some future > cleanups, as now a btrfs_bio is completely a continous range, thus > things like endio_readpage_release_extent() related infrastructure can > also be removed. Yes, there is a lot of things that can be cleaned up with this. For that reason along I was planning to look into a change like this eventually, but I should have done it earlier..