From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CADC25B08 for ; Sat, 13 Aug 2022 08:09:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236782AbiHMIJS (ORCPT ); Sat, 13 Aug 2022 04:09:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiHMIJR (ORCPT ); Sat, 13 Aug 2022 04:09:17 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E31222BA for ; Sat, 13 Aug 2022 01:09:17 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 8DA4F68AA6; Sat, 13 Aug 2022 10:09:13 +0200 (CEST) Date: Sat, 13 Aug 2022 10:09:13 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, Zygo Blaxell , Christoph Hellwig Subject: Re: [PATCH v2] btrfs: don't merge pages into bio if their page offset is not continuous Message-ID: <20220813080913.GA12088@lst.de> References: <1d9b69af6ce0a79e54fbaafcc65ead8f71b54b60.1660377678.git.wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d9b69af6ce0a79e54fbaafcc65ead8f71b54b60.1660377678.git.wqu@suse.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Aug 13, 2022 at 04:06:53PM +0800, Qu Wenruo wrote: > - bool contig; > + bool contig = false; Nit: the initialization isn't strictly needed in this new version. Otherwise looks good: Reviewed-by: Christoph Hellwig