Re: A sparse(make C=1) warning in btrfs about the 'blk_opf_t'

[Wang Yugui <wangyugui@e16-tech.com>]

Hi,

> On 8/12/22 21:53, Wang Yugui wrote:
> > both '__field(enum req_op,opf)' and '__field(blk_opf_t,opf)' failed to work.
> >
> > ./include/trace/events/btrfs.h:2327:1: warning: incorrect type in assignment (different base types)
> > ./include/trace/events/btrfs.h:2327:1:    expected unsigned int [usertype] opf
> > ./include/trace/events/btrfs.h:2327:1:    got restricted blk_opf_t enum req_op
> >
> > /ssd/git/os/linux-5.19/fs/btrfs/super.c: note: in included file (through include/trace/trace_events.h, include/trace/define_trace.h, include/trace/events/btrfs.h):
> > ./include/trace/events/btrfs.h:2327:1: warning: cast to restricted blk_opf_t
> > ./include/trace/events/btrfs.h:2327:1: warning: cast to restricted blk_opf_t
> > ./include/trace/events/btrfs.h:2327:1: warning: restricted blk_opf_t degrades to integer
> > ./include/trace/events/btrfs.h:2327:1: warning: restricted blk_opf_t degrades to integer
> 
>  From https://en.wikipedia.org/wiki/Posting_style:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?

Thanks for the comment.


> Regarding the warnings reported above: please apply patch "[PATCH] tracing: Suppress sparse warnings triggered by is_signed_type()" before testing my patch.
> 
> Thanks,
> 
> Bart.

After applied patch "[PATCH] tracing: Suppress sparse warnings triggered
by is_signed_type()",  both '__field(enum req_op,opf)' and 
'__field(blk_opf_t,opf)' work well without sparse warning(make C=1).

Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2022/08/13