From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: scrub: remove impossible sanity checks
Date: Thu, 18 Aug 2022 14:07:57 +0200 [thread overview]
Message-ID: <20220818120757.GG13489@twin.jikos.cz> (raw)
In-Reply-To: <85c8bd723773791d0b74028488a821b42d83d48f.1660111131.git.wqu@suse.com>
On Wed, Aug 10, 2022 at 01:58:57PM +0800, Qu Wenruo wrote:
> There are several sanity checks which are no longer possible to trigger
> inside btrfs_scrub_dev().
>
> Since we have mount time check against super block nodesize/sectorsize,
> and our fixed macro is hardcoded to handle even the worst combination.
>
> Thus those sanity checks are no longer needed, can be easily removed.
>
> But this patch still uses some ASSERT()s as a safe net just in case we
> change some features in the future to trigger those impossible
> combinations.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2022-08-18 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 5:58 [PATCH] btrfs: scrub: remove impossible sanity checks Qu Wenruo
2022-08-18 12:07 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818120757.GG13489@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox