Re: [PATCH 2/2] btrfs: add info when mount fails due to stale replace target

[David Sterba <dsterba@suse.cz>]

On Fri, Aug 12, 2022 at 06:32:19PM +0800, Anand Jain wrote:
> If the replace-target device re-appears after the suspended replace is
> cancelled, it blocks the mount operation as it can't find the matching
> replace-item in the metadata. As shown below,
> 
>    BTRFS error (device sda5): replace devid present without an active replace item
> 
> To overcome this situation, the user can run the command
> 
>    btrfs device scan --forget <device-path-to-devid=0>
> 
> and try the mount command again. And also, to avoid repeating the issue,
> superblock on the devid=0 must be wiped.
> 
>    wipefs -a device-path-to-devid=0.
> 
> This patch adds some info when this situation occurs.
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> Reported-by: Samuel Greiner <samuel@balkonien.org>
> Link: https://lore.kernel.org/linux-btrfs/b4f62b10-b295-26ea-71f9-9a5c9299d42c@balkonien.org/T/
> ---
>  fs/btrfs/dev-replace.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
> index 9d46a702bc11..7202b76ce59f 100644
> --- a/fs/btrfs/dev-replace.c
> +++ b/fs/btrfs/dev-replace.c
> @@ -166,6 +166,8 @@ int btrfs_init_dev_replace(struct btrfs_fs_info *fs_info)
>  		if (btrfs_find_device(fs_info->fs_devices, &args)) {
>  			btrfs_err(fs_info,
>  			"replace devid present without an active replace item");
> +			btrfs_info(fs_info,
> +	"mount after the command 'btrfs deivce scan --forget <devpath-of-id-0>'");

The messages should be on the same level and in one message, I've
reprhrased it a bit.