From: Christoph Hellwig <hch@lst.de>
To: dsterba@suse.cz, Zorro Lang <zlang@redhat.com>,
fdmanana@kernel.org, Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] btrfs: remove 'seek' group from btrfs/007
Date: Mon, 5 Sep 2022 08:35:39 +0200 [thread overview]
Message-ID: <20220905063539.GA2092@lst.de> (raw)
In-Reply-To: <20220902094424.GQ13489@twin.jikos.cz>
On Fri, Sep 02, 2022 at 11:44:24AM +0200, David Sterba wrote:
> > commit 6fd9210bc97710f81e5a7646a2abfd11af0f0c28
> > Author: Christoph Hellwig <hch@lst.de>
> > Date: Mon Feb 18 10:05:03 2019 +0100
> >
> > fstests: add a seek group
> >
> > So I'd like to let Christoph help to double check it.
>
> It's quite obvious from the test itself that it tests only send/receive,
> which is mentioned in the changelog. The commit adding the seek group
> does not provide any rationale so it's hard to argue but as it stands
> now the 'seek' group should not be there.
Probably. Unless it somehow exercised seeks through the userspace
seek code I can't see any good rationale for this addition, and the
patch was far too long ago for me to remember.
next prev parent reply other threads:[~2022-09-05 6:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 16:12 [PATCH] btrfs: remove 'seek' group from btrfs/007 fdmanana
2022-09-02 2:00 ` Zorro Lang
2022-09-02 9:44 ` David Sterba
2022-09-05 6:35 ` Christoph Hellwig [this message]
2022-09-05 9:08 ` Zorro Lang
2022-09-05 9:20 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905063539.GA2092@lst.de \
--to=hch@lst.de \
--cc=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox