Re: [PATCH] btrfs: zoned: wait extent buffer IOs before finishing a zone

[kernel test robot <lkp@intel.com>]

Hi Naohiro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on kdave/for-next]
[also build test WARNING on linus/master v6.0-rc4 next-20220907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Naohiro-Aota/btrfs-zoned-wait-extent-buffer-IOs-before-finishing-a-zone/20220907-224702
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: s390-randconfig-s041-20220907 (https://download.01.org/0day-ci/archive/20220908/202209080826.AuNlP9ys-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/f858e96a8ad7eb5499e18501bfbcaad594eace1f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Naohiro-Aota/btrfs-zoned-wait-extent-buffer-IOs-before-finishing-a-zone/20220907-224702
        git checkout f858e96a8ad7eb5499e18501bfbcaad594eace1f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
   fs/btrfs/zoned.c:137:29: sparse: sparse: restricted __le64 degrades to integer
   fs/btrfs/zoned.c:137:52: sparse: sparse: restricted __le64 degrades to integer
>> fs/btrfs/zoned.c:1932:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void **slot @@     got void [noderef] __rcu ** @@
   fs/btrfs/zoned.c:1932:9: sparse:     expected void **slot
   fs/btrfs/zoned.c:1932:9: sparse:     got void [noderef] __rcu **
>> fs/btrfs/zoned.c:1932:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void **slot @@     got void [noderef] __rcu ** @@
   fs/btrfs/zoned.c:1932:9: sparse:     expected void **slot
   fs/btrfs/zoned.c:1932:9: sparse:     got void [noderef] __rcu **
>> fs/btrfs/zoned.c:1934:44: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __rcu **slot @@     got void **slot @@
   fs/btrfs/zoned.c:1934:44: sparse:     expected void [noderef] __rcu **slot
   fs/btrfs/zoned.c:1934:44: sparse:     got void **slot
   fs/btrfs/zoned.c:1938:30: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void **slot @@     got void [noderef] __rcu ** @@
   fs/btrfs/zoned.c:1938:30: sparse:     expected void **slot
   fs/btrfs/zoned.c:1938:30: sparse:     got void [noderef] __rcu **
   fs/btrfs/zoned.c:1947:47: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __rcu **slot @@     got void **slot @@
   fs/btrfs/zoned.c:1947:47: sparse:     expected void [noderef] __rcu **slot
   fs/btrfs/zoned.c:1947:47: sparse:     got void **slot
   fs/btrfs/zoned.c:1947:22: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void **slot @@     got void [noderef] __rcu ** @@
   fs/btrfs/zoned.c:1947:22: sparse:     expected void **slot
   fs/btrfs/zoned.c:1947:22: sparse:     got void [noderef] __rcu **
   fs/btrfs/zoned.c:1932:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __rcu **slot @@     got void **slot @@
   fs/btrfs/zoned.c:1932:9: sparse:     expected void [noderef] __rcu **slot
   fs/btrfs/zoned.c:1932:9: sparse:     got void **slot
>> fs/btrfs/zoned.c:1932:9: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void **slot @@     got void [noderef] __rcu ** @@
   fs/btrfs/zoned.c:1932:9: sparse:     expected void **slot
   fs/btrfs/zoned.c:1932:9: sparse:     got void [noderef] __rcu **
   fs/btrfs/zoned.c:2303:25: sparse: sparse: context imbalance in 'btrfs_zoned_activate_one_bg' - different lock contexts for basic block

vim +1932 fs/btrfs/zoned.c

  1922	
  1923	static void wait_eb_writebacks(struct btrfs_block_group *block_group)
  1924	{
  1925		struct btrfs_fs_info *fs_info = block_group->fs_info;
  1926		const u64 end = block_group->start + block_group->length;
  1927		struct radix_tree_iter iter;
  1928		struct extent_buffer *eb;
  1929		void **slot;
  1930	
  1931		rcu_read_lock();
> 1932		radix_tree_for_each_slot(slot, &fs_info->buffer_radix, &iter,
  1933					 block_group->start >> fs_info->sectorsize_bits) {
> 1934			eb = radix_tree_deref_slot(slot);
  1935			if (!eb)
  1936				continue;
  1937			if (radix_tree_deref_retry(eb)) {
  1938				slot = radix_tree_iter_retry(&iter);
  1939				continue;
  1940			}
  1941	
  1942			if (eb->start < block_group->start)
  1943				continue;
  1944			if (eb->start >= end)
  1945				break;
  1946	
  1947			slot = radix_tree_iter_resume(slot, &iter);
  1948			rcu_read_unlock();
  1949			wait_on_extent_buffer_writeback(eb);
  1950			rcu_read_lock();
  1951		}
  1952		rcu_read_unlock();
  1953	}
  1954	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp