Hi Josef, I love your patch! Perhaps something to improve: [auto build test WARNING on kdave/for-next] [also build test WARNING on next-20220909] [cannot apply to rostedt-trace/for-next linus/master v6.0-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Josef-Bacik/btrfs-move-extent_io_tree-code-and-cleanups/20220910-055740 base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next config: x86_64-randconfig-a011 compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/928ccd4819fcceec3291cec09aa9bc1d343a53c0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Josef-Bacik/btrfs-move-extent_io_tree-code-and-cleanups/20220910-055740 git checkout 928ccd4819fcceec3291cec09aa9bc1d343a53c0 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/btrfs/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> fs/btrfs/extent-io-tree.c:165: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Search @tree for an entry that contains @offset. Such entry would have fs/btrfs/extent-io-tree.c:217: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Search offset in the tree or fill neighbor rbtree node pointers. vim +165 fs/btrfs/extent-io-tree.c 163 164 /** > 165 * Search @tree for an entry that contains @offset. Such entry would have 166 * entry->start <= offset && entry->end >= offset. 167 * 168 * @tree: the tree to search 169 * @offset: offset that should fall within an entry in @tree 170 * @node_ret: pointer where new node should be anchored (used when inserting an 171 * entry in the tree) 172 * @parent_ret: points to entry which would have been the parent of the entry, 173 * containing @offset 174 * 175 * Return a pointer to the entry that contains @offset byte address and don't change 176 * @node_ret and @parent_ret. 177 * 178 * If no such entry exists, return pointer to entry that ends before @offset 179 * and fill parameters @node_ret and @parent_ret, ie. does not return NULL. 180 */ 181 struct rb_node *tree_search_for_insert(struct extent_io_tree *tree, u64 offset, 182 struct rb_node ***node_ret, 183 struct rb_node **parent_ret) 184 { 185 struct rb_root *root = &tree->state; 186 struct rb_node **node = &root->rb_node; 187 struct rb_node *prev = NULL; 188 struct tree_entry *entry; 189 190 while (*node) { 191 prev = *node; 192 entry = rb_entry(prev, struct tree_entry, rb_node); 193 194 if (offset < entry->start) 195 node = &(*node)->rb_left; 196 else if (offset > entry->end) 197 node = &(*node)->rb_right; 198 else 199 return *node; 200 } 201 202 if (node_ret) 203 *node_ret = node; 204 if (parent_ret) 205 *parent_ret = prev; 206 207 /* Search neighbors until we find the first one past the end */ 208 while (prev && offset > entry->end) { 209 prev = rb_next(prev); 210 entry = rb_entry(prev, struct tree_entry, rb_node); 211 } 212 213 return prev; 214 } 215 -- 0-DAY CI Kernel Test Service https://01.org/lkp