Re: [PATCH] btrfs-progs: fi resize: fix return value check_resize_args()

[David Sterba <dsterba@suse.cz>]

On Mon, Sep 12, 2022 at 03:58:47PM +0800, Wang Yugui wrote:
> Hi,
> 
> > check_resize_args() function checks user argument amount and should
> > returns it's validity. But now the code returns only zero. This patch
> > make it correct to return ret.
> > 
> > Signed-off-by: Sidong Yang <realwakka@gmail.com>
> > ---
> >  cmds/filesystem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/cmds/filesystem.c b/cmds/filesystem.c
> > index 7cd08fcd..9eff5680 100644
> > --- a/cmds/filesystem.c
> > +++ b/cmds/filesystem.c
> > @@ -1203,7 +1203,7 @@ static int check_resize_args(const char *amount, const char *path) {
> >  
> >  out:
> >  	free(di_args);
> > -	return 0;
> > +	return ret;
> >  }
> >  
> >  static int cmd_filesystem_resize(const struct cmd_struct *cmd,
> 
> This patch will make 'btrfs filesystem resize' always fail, and then break
> fstests btrfs/177.

I noticed that too when doing the progs release so the patch will be
dropped.