public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Pankaj Raghav <pankydev8@gmail.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: dsterba@suse.com, johannes.thumshirn@wdc.com,
	naohiro.aota@wdc.com, linux-btrfs@vger.kernel.org,
	damien.lemoal@wdc.com, p.raghav@samsung.com
Subject: Re: [PATCH 1/2] btrfs-progs: mkfs: fix error message for minimum zoned filesystem size
Date: Wed, 14 Sep 2022 10:28:40 +0200	[thread overview]
Message-ID: <20220914082840.ix2x35fdvrlycggw@quentin> (raw)
In-Reply-To: <20220909214810.761928-2-mcgrof@kernel.org>

> With this now the user sees:
> 
> ERROR: Size 512.00MiB is too small to make a usable filesystem.
> ERROR: The minimum size for a zoned btrfs filesystem requires
> ERROR: 5 dedicated zones. This device's zone size is 128.00MiB so
> ERROR: the minimum size for a btrfs filesystem for this zoned
> ERROR: storage device (/dev/nvme5n1) is 640.00MiB
> 
> The following fstests fail because of this issue, and at first glance
> it was not clear why:
> 
>   * brfs/132
>   * generic/226
>   * generic/416
>   * generic/650
> 
> Now it's clear what the issue is and what needs to get done to
> fix those respective tests. But note, that if working on a sequential
> zone then parallel writes are expected to fail, so tests which require
> that and use parallel writes must also check for sequential zones
> and bail if one is to be used. Each of these tests needs to be adapted
> a bit for zoned devices to work properly.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
Looks good,
Reviewed-by: Pankaj Raghav <p.raghav@samsung.com>

  reply	other threads:[~2022-09-14  8:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 21:48 [PATCH 0/2] btrfs-progs: minor mkfs fs size error message enhancements Luis Chamberlain
2022-09-09 21:48 ` [PATCH 1/2] btrfs-progs: mkfs: fix error message for minimum zoned filesystem size Luis Chamberlain
2022-09-14  8:28   ` Pankaj Raghav [this message]
2022-09-09 21:48 ` [PATCH 2/2] btrfs-progs: mkfs: use pretty_size_mode() on min size error Luis Chamberlain
2022-09-09 23:10   ` Wang Yugui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220914082840.ix2x35fdvrlycggw@quentin \
    --to=pankydev8@gmail.com \
    --cc=damien.lemoal@wdc.com \
    --cc=dsterba@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=p.raghav@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox