public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/3] btrfs: optimize the argument list for submit_extent_page()
Date: Wed, 21 Sep 2022 11:18:18 +0200	[thread overview]
Message-ID: <20220921091818.GA32411@twin.jikos.cz> (raw)
In-Reply-To: <cover.1663046855.git.wqu@suse.com>

On Tue, Sep 13, 2022 at 01:31:11PM +0800, Qu Wenruo wrote:
> [Changelog]
> v2:
> - Add a patch to remove stale argument from the comments of
>   submit_extent_page()
> 
> - Update the comment of submit_extent_page() to reflect the new arugment
>   list
> 
> The argument list of submit_extent_page() is already a little long.
> 
> Although we have things like page, pg_len, pg_off which can not be saved
> anyway, we can still improve the situation by:
> 
> - Update the stale comment of submit_extent_page()
>   Done by the first patch.
> 
> - Make sure @page, @pg_len, @pg_off are always batched together
>   Just like bio_add_page().
> 
>   This is done by the second page, just switching the position between
>   @page and @disk_bytenr.
> 
> - Move @end_io_func arugment into btrfs_bio_ctrl structure.
> 
> Qu Wenruo (3):
>   btrfs: update the comment for submit_extent_page()
>   btrfs: switch the page and disk_bytenr argument position for
>     submit_extent_page()
>   btrfs: move end_io_func argument to btrfs_bio_ctrl structure

Added to misc-next, thanks.

      parent reply	other threads:[~2022-09-21  9:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  5:31 [PATCH v2 0/3] btrfs: optimize the argument list for submit_extent_page() Qu Wenruo
2022-09-13  5:31 ` [PATCH v2 1/3] btrfs: update the comment " Qu Wenruo
2022-09-13  6:01   ` Anand Jain
2022-09-13  5:31 ` [PATCH v2 2/3] btrfs: switch the page and disk_bytenr argument position " Qu Wenruo
2022-09-13  5:31 ` [PATCH v2 3/3] btrfs: move end_io_func argument to btrfs_bio_ctrl structure Qu Wenruo
2022-09-21  9:18 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220921091818.GA32411@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox