From: Wang Yugui <wangyugui@e16-tech.com>
To: linux-btrfs@vger.kernel.org
Cc: Wang Yugui <wangyugui@e16-tech.com>
Subject: [PATCH v2] btrfs-progs: balance: deprecate old syntax
Date: Thu, 22 Sep 2022 05:54:42 +0800 [thread overview]
Message-ID: <20220921215442.65360-1-wangyugui@e16-tech.com> (raw)
In-Reply-To: <20220914055846.52008-1-wangyugui@e16-tech.com>
deprecate btrfs blanace old syntax since new syntax is already introduced in
2012.
we will remove the old syntax completely in a few releases.
Signed-off-by: Wang Yugui <wangyugui@e16-tech.com>
---
changes since v1:
fix typo(btrfs balance replace -> btrfs balance start)
cmds/balance.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmds/balance.c b/cmds/balance.c
index d1e66d42..3cb6334a 100644
--- a/cmds/balance.c
+++ b/cmds/balance.c
@@ -37,7 +37,7 @@
static const char * const balance_cmd_group_usage[] = {
"btrfs balance <command> [options] <path>",
- "btrfs balance <path>",
+ "btrfs balance <path> deprecated by 'btrfs balance start'",
NULL
};
@@ -882,6 +882,8 @@ static int cmd_balance(const struct cmd_struct *cmd, int argc, char **argv)
/* old 'btrfs filesystem balance <path>' syntax */
struct btrfs_ioctl_balance_args args;
+ warning("deprecated by 'btrfs balance start'");
+
memset(&args, 0, sizeof(args));
args.flags |= BTRFS_BALANCE_TYPE_MASK;
--
2.36.2
next prev parent reply other threads:[~2022-09-21 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 5:58 [PATCH] btrfs-progs: balance: fix some cases wrongly parsed as old syntax Wang Yugui
2022-09-14 7:11 ` Qu Wenruo
2022-09-21 8:24 ` David Sterba
2022-09-21 15:34 ` [PATCH] btrfs-progs: balance: deprecate " Wang Yugui
2022-09-21 21:54 ` Wang Yugui [this message]
2023-03-16 15:47 ` [PATCH] btrfs-progs: balance: fix some cases wrongly parsed as " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921215442.65360-1-wangyugui@e16-tech.com \
--to=wangyugui@e16-tech.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox