From: David Sterba <dsterba@suse.cz>
To: Zorro Lang <zlang@redhat.com>
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] btrfs: test active zone tracking
Date: Thu, 29 Sep 2022 14:04:00 +0200 [thread overview]
Message-ID: <20220929120400.GG13389@twin.jikos.cz> (raw)
In-Reply-To: <20220929060106.dy7enioljc3hi3lt@zlang-mailbox>
On Thu, Sep 29, 2022 at 02:01:06PM +0800, Zorro Lang wrote:
> On Thu, Sep 29, 2022 at 01:19:25PM +0900, Naohiro Aota wrote:
> > A ZNS device limits the number of active zones, which is the number of
> > zones can be written at the same time. To deal with the limit, btrfs's
> > zoned mode tracks which zone (corresponds to a block group on the SINGLE
> > profile) is active, and finish a zone if necessary.
> >
> > This test checks if the active zone tracking and the finishing of zones
> > works properly. First, it fills <number of max active zones> zones
> > mostly. And, run some data/metadata stress workload to force btrfs to use a
> > new zone.
> >
> > This test fails on an older kernel (e.g, 5.18.2) like below.
> >
> > btrfs/292
> > [failed, exit status 1]- output mismatch (see /host/btrfs/292.out.bad)
> > --- tests/btrfs/292.out 2022-09-15 07:52:18.000000000 +0000
> > +++ /host/btrfs/292.out.bad 2022-09-15 07:59:14.290967793 +0000
> > @@ -1,2 +1,5 @@
> > QA output created by 292
> > -Silence is golden
> > +stress_data_bgs failed
> > +stress_data_bgs_2 failed
> > +failed: '/bin/btrfs subvolume snapshot /mnt/scratch /mnt/scratch/snap825'
> > +(see /host/btrfs/292.full for details)
> > ...
> > (Run 'diff -u /var/lib/xfstests/tests/btrfs/292.out /host/btrfs/292.out.bad' to see the entire diff)
> >
> > The failure is fixed with a series "btrfs: zoned: fix active zone tracking
> > issues" [1] (upstream commits from 65ea1b66482f ("block: add bdev_max_segments()
> > helper") to 2ce543f47843 ("btrfs: zoned: wait until zone is finished when
> > allocation didn't progress")).
>
> If this's a regression test case for known fix, we'd better to use:
> _fixed_by_kernel_commit 65ea1b66482f block: add bdev_max_segments (patchset)
This is very misleading as the commit only adds a helper that's used in
later commits. If anything, the last commit in the series should be
mentioned.
next prev parent reply other threads:[~2022-09-29 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 4:19 [PATCH v2 0/2] btrfs: test active zone tracking Naohiro Aota
2022-09-29 4:19 ` [PATCH v2 1/2] common: introduce zone_capacity() to return a zone capacity Naohiro Aota
2022-09-29 5:15 ` Zorro Lang
2022-09-30 6:19 ` Naohiro Aota
2022-09-29 4:19 ` [PATCH v2 2/2] btrfs: test active zone tracking Naohiro Aota
2022-09-29 6:01 ` Zorro Lang
2022-09-29 12:04 ` David Sterba [this message]
2022-09-29 14:06 ` Zorro Lang
2022-09-30 6:21 ` Naohiro Aota
2022-09-30 6:29 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929120400.GG13389@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).