From: Zorro Lang <zlang@redhat.com>
To: fdmanana@kernel.org
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH 0/3] fstests: add a btrfs fiemap test and fiemap test group
Date: Sat, 8 Oct 2022 11:16:19 +0800 [thread overview]
Message-ID: <20221008031619.7zwzzgdgr7q3b4pw@zlang-mailbox> (raw)
In-Reply-To: <cover.1665150613.git.fdmanana@suse.com>
On Fri, Oct 07, 2022 at 02:53:33PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> Add a new btrfs test case to exercise fiemap in the presence of a
> snapshot, and then add a fiemap test group, as well as some missing
> '_require_xfs_io_command "fiemap"' calls in a few tests.
>
> Filipe Manana (3):
> btrfs: test fiemap on large file with extents shared through a snapshot
> fstests: add missing require of xfs_io fiemap command to some tests
> fstests: add fiemap group
Thanks for doing this! The 1st patch looks good to me, the 2nd is fine too.
If you're hurry (Are you?) to have that btrfs test coverage, I can merge the
1st patch at first. Then keep other patch one more week. Due to it changes
many other fs cases (although not big change:), I need time to check one by
one, and I hope to see if there're more review points from others :)
Thanks,
Zorro
>
> doc/group-names.txt | 1 +
> tests/btrfs/004 | 2 +-
> tests/btrfs/079 | 2 +-
> tests/btrfs/137 | 2 +-
> tests/btrfs/140 | 2 +-
> tests/btrfs/199 | 2 +-
> tests/btrfs/200 | 2 +-
> tests/btrfs/211 | 2 +-
> tests/btrfs/257 | 3 +-
> tests/btrfs/258 | 3 +-
> tests/btrfs/259 | 3 +-
> tests/btrfs/260 | 2 +-
> tests/btrfs/263 | 2 +-
> tests/btrfs/276 | 124 ++++++++++++++++++++++++++++++++++++++++++++
> tests/btrfs/276.out | 16 ++++++
> tests/ext4/001 | 2 +-
> tests/ext4/034 | 2 +-
> tests/ext4/308 | 2 +-
> tests/f2fs/002 | 2 +-
> tests/generic/009 | 2 +-
> tests/generic/012 | 2 +-
> tests/generic/016 | 2 +-
> tests/generic/017 | 2 +-
> tests/generic/021 | 2 +-
> tests/generic/022 | 2 +-
> tests/generic/032 | 2 +-
> tests/generic/043 | 2 +-
> tests/generic/044 | 2 +-
> tests/generic/045 | 2 +-
> tests/generic/046 | 2 +-
> tests/generic/047 | 2 +-
> tests/generic/048 | 2 +-
> tests/generic/049 | 2 +-
> tests/generic/058 | 2 +-
> tests/generic/060 | 2 +-
> tests/generic/061 | 2 +-
> tests/generic/063 | 2 +-
> tests/generic/064 | 2 +-
> tests/generic/092 | 2 +-
> tests/generic/094 | 2 +-
> tests/generic/110 | 2 +-
> tests/generic/111 | 2 +-
> tests/generic/115 | 2 +-
> tests/generic/177 | 2 +-
> tests/generic/225 | 2 +-
> tests/generic/255 | 2 +-
> tests/generic/301 | 2 +-
> tests/generic/302 | 2 +-
> tests/generic/305 | 2 +-
> tests/generic/316 | 2 +-
> tests/generic/326 | 2 +-
> tests/generic/327 | 2 +-
> tests/generic/328 | 2 +-
> tests/generic/352 | 2 +-
> tests/generic/353 | 2 +-
> tests/generic/372 | 2 +-
> tests/generic/414 | 2 +-
> tests/generic/425 | 2 +-
> tests/generic/473 | 2 +-
> tests/generic/483 | 2 +-
> tests/generic/516 | 2 +-
> tests/generic/519 | 2 +-
> tests/generic/540 | 2 +-
> tests/generic/541 | 2 +-
> tests/generic/542 | 2 +-
> tests/generic/543 | 2 +-
> tests/generic/578 | 2 +-
> tests/generic/654 | 2 +-
> tests/generic/655 | 2 +-
> tests/generic/677 | 2 +-
> tests/generic/679 | 2 +-
> tests/generic/695 | 2 +-
> tests/overlay/066 | 2 +-
> tests/shared/298 | 2 +-
> tests/xfs/180 | 2 +-
> tests/xfs/182 | 2 +-
> tests/xfs/184 | 2 +-
> tests/xfs/192 | 2 +-
> tests/xfs/193 | 2 +-
> tests/xfs/198 | 2 +-
> tests/xfs/200 | 2 +-
> tests/xfs/204 | 2 +-
> tests/xfs/207 | 2 +-
> tests/xfs/208 | 2 +-
> tests/xfs/209 | 2 +-
> tests/xfs/210 | 2 +-
> tests/xfs/211 | 2 +-
> tests/xfs/212 | 2 +-
> tests/xfs/213 | 2 +-
> tests/xfs/214 | 2 +-
> tests/xfs/231 | 2 +-
> tests/xfs/232 | 2 +-
> tests/xfs/252 | 2 +-
> tests/xfs/344 | 2 +-
> tests/xfs/345 | 2 +-
> tests/xfs/346 | 2 +-
> tests/xfs/347 | 2 +-
> tests/xfs/443 | 3 +-
> 98 files changed, 240 insertions(+), 95 deletions(-)
> create mode 100755 tests/btrfs/276
> create mode 100644 tests/btrfs/276.out
>
> --
> 2.35.1
>
prev parent reply other threads:[~2022-10-08 3:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 13:53 [PATCH 0/3] fstests: add a btrfs fiemap test and fiemap test group fdmanana
2022-10-07 13:53 ` [PATCH 1/3] btrfs: test fiemap on large file with extents shared through a snapshot fdmanana
2022-10-08 3:27 ` Zorro Lang
2022-10-07 13:53 ` [PATCH 2/3] fstests: add missing require of xfs_io fiemap command to some tests fdmanana
2022-10-11 13:56 ` Zorro Lang
2022-10-11 17:38 ` Darrick J. Wong
2022-10-07 13:53 ` [PATCH 3/3] fstests: add fiemap group fdmanana
2022-10-11 13:55 ` Zorro Lang
2022-10-11 17:45 ` Darrick J. Wong
2022-10-08 3:16 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221008031619.7zwzzgdgr7q3b4pw@zlang-mailbox \
--to=zlang@redhat.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).