From: Christoph Hellwig <hch@lst.de>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>
Cc: Qu Wenruo <wqu@suse.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
linux-btrfs@vger.kernel.org
Subject: [PATCH 1/3] btrfs: move struct btrfs_tree_parent_check out of disk-io.h
Date: Tue, 15 Nov 2022 10:44:04 +0100 [thread overview]
Message-ID: <20221115094407.1626250-2-hch@lst.de> (raw)
In-Reply-To: <20221115094407.1626250-1-hch@lst.de>
Move struct btrfs_tree_parent_check out of disk-io.h so that volumes.h
an various .c files don't have to include disk-io.h just for it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/backref.c | 1 +
fs/btrfs/disk-io.h | 30 +-----------------------------
fs/btrfs/parent-check.h | 36 ++++++++++++++++++++++++++++++++++++
fs/btrfs/print-tree.c | 1 +
fs/btrfs/qgroup.c | 1 +
fs/btrfs/tree-mod-log.c | 1 +
fs/btrfs/volumes.h | 2 +-
7 files changed, 42 insertions(+), 30 deletions(-)
create mode 100644 fs/btrfs/parent-check.h
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 55c072ba67471..9496aa93a8dcc 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -19,6 +19,7 @@
#include "accessors.h"
#include "extent-tree.h"
#include "relocation.h"
+#include "parent-check.h"
/* Just arbitrary numbers so we can be sure one of these happened. */
#define BACKREF_FOUND_SHARED 6
diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h
index 03fe4154ffb83..363935cfc0844 100644
--- a/fs/btrfs/disk-io.h
+++ b/fs/btrfs/disk-io.h
@@ -25,37 +25,9 @@ static inline u64 btrfs_sb_offset(int mirror)
return BTRFS_SUPER_INFO_OFFSET;
}
-/* All the extra info needed to verify the parentness of a tree block. */
-struct btrfs_tree_parent_check {
- /*
- * The owner check against the tree block.
- *
- * Can be 0 to skip the owner check.
- */
- u64 owner_root;
-
- /*
- * Expected transid, can be 0 to skip the check, but such skip
- * should only be utlized for backref walk related code.
- */
- u64 transid;
-
- /*
- * The expected first key.
- *
- * This check can be skipped if @has_first_key is false, such skip
- * can happen for case where we don't have the parent node key,
- * e.g. reading the tree root, doing backref walk.
- */
- struct btrfs_key first_key;
- bool has_first_key;
-
- /* The expected level. Should always be set. */
- u8 level;
-};
-
struct btrfs_device;
struct btrfs_fs_devices;
+struct btrfs_tree_parent_check;
void btrfs_check_leaked_roots(struct btrfs_fs_info *fs_info);
void btrfs_init_fs_info(struct btrfs_fs_info *fs_info);
diff --git a/fs/btrfs/parent-check.h b/fs/btrfs/parent-check.h
new file mode 100644
index 0000000000000..333f23ea28e25
--- /dev/null
+++ b/fs/btrfs/parent-check.h
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef BTRFS_PARENT_CHECK_H
+#define BTRFS_PARENT_CHECK_H
+
+#include <uapi/linux/btrfs_tree.h>
+
+/* All the extra info needed to verify the parentness of a tree block. */
+struct btrfs_tree_parent_check {
+ /*
+ * The owner check against the tree block.
+ *
+ * Can be 0 to skip the owner check.
+ */
+ u64 owner_root;
+
+ /*
+ * Expected transid, can be 0 to skip the check, but such skip
+ * should only be utlized for backref walk related code.
+ */
+ u64 transid;
+
+ /*
+ * The expected first key.
+ *
+ * This check can be skipped if @has_first_key is false, such skip
+ * can happen for case where we don't have the parent node key,
+ * e.g. reading the tree root, doing backref walk.
+ */
+ struct btrfs_key first_key;
+ bool has_first_key;
+
+ /* The expected level. Should always be set. */
+ u8 level;
+};
+
+#endif /* BTRFS_PARENT_CHECK_H */
diff --git a/fs/btrfs/print-tree.c b/fs/btrfs/print-tree.c
index 1469aa55ad482..00d5da5f3c333 100644
--- a/fs/btrfs/print-tree.c
+++ b/fs/btrfs/print-tree.c
@@ -8,6 +8,7 @@
#include "disk-io.h"
#include "print-tree.h"
#include "accessors.h"
+#include "parent-check.h"
struct root_name_map {
u64 id;
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 05e79f7b4433a..365482ad0421b 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -28,6 +28,7 @@
#include "accessors.h"
#include "extent-tree.h"
#include "root-tree.h"
+#include "parent-check.h"
/*
* Helpers to access qgroup reservation
diff --git a/fs/btrfs/tree-mod-log.c b/fs/btrfs/tree-mod-log.c
index 779ad44d285f8..5b91a2a88a398 100644
--- a/fs/btrfs/tree-mod-log.c
+++ b/fs/btrfs/tree-mod-log.c
@@ -5,6 +5,7 @@
#include "disk-io.h"
#include "fs.h"
#include "accessors.h"
+#include "parent-check.h"
struct tree_mod_root {
u64 logical;
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index 2c90e50c460a3..7467df319d3b2 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -11,7 +11,7 @@
#include <linux/btrfs.h>
#include "async-thread.h"
#include "messages.h"
-#include "disk-io.h"
+#include "parent-check.h"
#include "rcu-string.h"
#define BTRFS_MAX_DATA_CHUNK_SIZE (10ULL * SZ_1G)
--
2.30.2
next prev parent reply other threads:[~2022-11-15 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 9:44 move the low-level btrfs_bio code into a separate file v3 Christoph Hellwig
2022-11-15 9:44 ` Christoph Hellwig [this message]
2022-11-15 14:38 ` [PATCH 1/3] btrfs: move struct btrfs_tree_parent_check out of disk-io.h Josef Bacik
2022-11-18 14:07 ` David Sterba
2022-11-20 12:41 ` Christoph Hellwig
2022-11-23 17:17 ` David Sterba
2022-11-15 9:44 ` [PATCH 2/3] btrfs: split the bio submission path into a separate file Christoph Hellwig
2022-11-15 9:44 ` [PATCH 3/3] btrfs: move repair_io_failure to bio.c Christoph Hellwig
2022-11-18 16:01 ` move the low-level btrfs_bio code into a separate file v3 David Sterba
-- strict thread matches above, loose matches on Subject: below --
2022-11-13 16:24 move the low-level btrfs_bio code into a separate file v2 Christoph Hellwig
2022-11-13 16:24 ` [PATCH 1/3] btrfs: move struct btrfs_tree_parent_check out of disk-io.h Christoph Hellwig
2022-11-13 22:28 ` Qu Wenruo
2022-11-14 8:06 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115094407.1626250-2-hch@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox