From: Wang Yugui <wangyugui@e16-tech.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-btrfs@vger.kernel.org, stable@vger.kernel.org
Subject: Re: please rebase the patch queue-6.1(btrfs: fix an error handling path in btrfs_defrag_leaves)
Date: Tue, 10 Jan 2023 16:42:35 +0800 [thread overview]
Message-ID: <20230110164234.14C5.409509F4@e16-tech.com> (raw)
In-Reply-To: <Y70aTKUaBOLah8EQ@kroah.com>
Hi,
> On Tue, Jan 10, 2023 at 12:38:14PM +0800, Wang Yugui wrote:
> > Hi, Sasha Levin
> >
> > please rebase the patch queue-6.1(btrfs: fix an error handling path in btrfs_defrag_leaves)
> > just like queue-6.0, and then drop its 8 depency patches.
> >
> > the 2 of 8 depency patches are file rename, so it will make later depency patch become
> > difficult?
> > #btrfs-move-btrfs_get_block_group-helper-out-of-disk-.patch
> > #btrfs-move-flush-related-definitions-to-space-info.h.patch
> > #btrfs-move-btrfs_print_data_csum_error-into-inode.c.patch
> > #btrfs-move-fs-wide-helpers-out-of-ctree.h.patch
> > #btrfs-move-assert-helpers-out-of-ctree.h.patch
> > #btrfs-move-the-printk-helpers-out-of-ctree.h.patch
> > #**btrfs-rename-struct-funcs.c-to-accessors.c.patch
> > #**btrfs-rename-tree-defrag.c-to-defrag.c.patch
> >
> > and the patch(btrfs: fix an error handling path in btrfs_defrag_leaves) is small,
> > so a rebase will be a good choice.
>
> I do not understand, sorry, we can not rebase anything, that's not how
> our patch queue works.
>
> So what exactly do you want to see changed? What patches dropped? And
> what added?
What I suggest:
1)replace queue-6.1/btrfs-fix-an-error-handling-path-in-btrfs_defrag_lea.patch
with queue-6.0/btrfs-fix-an-error-handling-path-in-btrfs_defrag_lea.patch
2) drop pathes in queue-6.1/
btrfs-move-btrfs_get_block_group-helper-out-of-disk-.patch
btrfs-move-flush-related-definitions-to-space-info.h.patch
btrfs-move-btrfs_print_data_csum_error-into-inode.c.patch
btrfs-move-fs-wide-helpers-out-of-ctree.h.patch
btrfs-move-assert-helpers-out-of-ctree.h.patch
btrfs-move-the-printk-helpers-out-of-ctree.h.patch
btrfs-rename-struct-funcs.c-to-accessors.c.patch
btrfs-rename-tree-defrag.c-to-defrag.c.patch
Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2023/01/10
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2023-01-10 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 4:38 please rebase the patch queue-6.1(btrfs: fix an error handling path in btrfs_defrag_leaves) Wang Yugui
2023-01-10 7:57 ` Greg KH
2023-01-10 8:42 ` Wang Yugui [this message]
2023-01-10 14:30 ` David Sterba
2023-01-10 15:26 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110164234.14C5.409509F4@e16-tech.com \
--to=wangyugui@e16-tech.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox