From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 04/10] btrfs: add a bio_list_put helper
Date: Thu, 12 Jan 2023 09:09:52 +0100 [thread overview]
Message-ID: <20230112080952.GA12947@lst.de> (raw)
In-Reply-To: <2e946375-bfdb-7361-842d-c0b40e206298@wdc.com>
On Wed, Jan 11, 2023 at 11:12:21AM +0000, Johannes Thumshirn wrote:
> On 11.01.23 07:24, Christoph Hellwig wrote:
> > +static inline void bio_list_put(struct bio_list *bio_list)
> > +{
> > + struct bio *bio;
> > +
> > + while ((bio = bio_list_pop(bio_list)))
> > + bio_put(bio);
> > +}
> > +
>
> Shouldn't that be lifted into bio.h? At least
> drivers/target/target_core_iblock.c would benefit from it as well.
That is in fact the only other two callers, out of which one is bogus
as we don't even need the list there (Write Same just has a single
block payload). So for now I'd prefer to not move it to common
code.
next prev parent reply other threads:[~2023-01-12 8:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 6:23 small raid56 cleanups v3 Christoph Hellwig
2023-01-11 6:23 ` [PATCH 01/10] btrfs: cleanup raid56_parity_write Christoph Hellwig
2023-01-11 6:23 ` [PATCH 02/10] btrfs: cleanup rmw_rbio Christoph Hellwig
2023-01-11 6:23 ` [PATCH 03/10] btrfs: wait for I/O completion in submit_read_bios Christoph Hellwig
2023-01-11 6:38 ` Qu Wenruo
2023-01-11 6:23 ` [PATCH 04/10] btrfs: add a bio_list_put helper Christoph Hellwig
2023-01-11 6:38 ` Qu Wenruo
2023-01-11 11:12 ` Johannes Thumshirn
2023-01-12 8:09 ` Christoph Hellwig [this message]
2023-01-12 11:00 ` Johannes Thumshirn
2023-01-11 6:23 ` [PATCH 05/10] btrfs: fold recover_assemble_read_bios into recover_rbio Christoph Hellwig
2023-01-11 6:42 ` Qu Wenruo
2023-01-11 6:23 ` [PATCH 06/10] btrfs: fold rmw_read_wait_recover into rmw_read_bios Christoph Hellwig
2023-01-11 6:45 ` Qu Wenruo
2023-01-11 6:23 ` [PATCH 07/10] btrfs: submit the read bios from scrub_assemble_read_bios Christoph Hellwig
2023-01-11 6:48 ` Qu Wenruo
2023-01-11 6:23 ` [PATCH 08/10] btrfs: call rbio_orig_end_io from rmw_rbio Christoph Hellwig
2023-01-11 6:49 ` Qu Wenruo
2023-01-11 6:23 ` [PATCH 09/10] btrfs: call rbio_orig_end_io from recover_rbio Christoph Hellwig
2023-01-11 6:50 ` Qu Wenruo
2023-01-11 6:23 ` [PATCH 10/10] btrfs: call rbio_orig_end_io from scrub_rbio Christoph Hellwig
2023-01-11 6:50 ` Qu Wenruo
2023-01-11 11:18 ` small raid56 cleanups v3 Johannes Thumshirn
2023-02-08 20:00 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112080952.GA12947@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox