* [PATCH] btrfs: raid56: Fix stripes if vertical errors are found
@ 2023-01-15 20:32 Tanmay Bhushan
2023-01-15 23:37 ` Qu Wenruo
2023-01-25 19:11 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Tanmay Bhushan @ 2023-01-15 20:32 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
Cc: Tanmay Bhushan
We take two stripe numbers if vertical errors are found.
In case it is just a pstripe it does not matter but in
case of raid 6 it matters a both stripes need to be fixed.
Signed-off-by: Tanmay Bhushan <007047221b@gmail.com>
---
fs/btrfs/raid56.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index 6a2cf754912d..f35898a78b16 100644
--- a/fs/btrfs/raid56.c
+++ b/fs/btrfs/raid56.c
@@ -1886,7 +1886,7 @@ static int recover_vertical(struct btrfs_raid_bio *rbio, int sector_nr,
sector->uptodate = 1;
}
if (failb >= 0) {
- ret = verify_one_sector(rbio, faila, sector_nr);
+ ret = verify_one_sector(rbio, failb, sector_nr);
if (ret < 0)
goto cleanup;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs: raid56: Fix stripes if vertical errors are found
2023-01-15 20:32 [PATCH] btrfs: raid56: Fix stripes if vertical errors are found Tanmay Bhushan
@ 2023-01-15 23:37 ` Qu Wenruo
2023-01-25 19:11 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Qu Wenruo @ 2023-01-15 23:37 UTC (permalink / raw)
To: Tanmay Bhushan, Chris Mason, Josef Bacik, David Sterba,
linux-btrfs, linux-kernel
On 2023/1/16 04:32, Tanmay Bhushan wrote:
> We take two stripe numbers if vertical errors are found.
> In case it is just a pstripe it does not matter but in
> case of raid 6 it matters a both stripes need to be fixed.
>
> Signed-off-by: Tanmay Bhushan <007047221b@gmail.com>
Oh, my bad, typical copy-and-paste error.
Should go in to the next rc.
Fixes: 7a3150723061 ("btrfs: raid56: do data csum verification during
RMW cycle")
Thanks,
Qu
> ---
> fs/btrfs/raid56.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index 6a2cf754912d..f35898a78b16 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -1886,7 +1886,7 @@ static int recover_vertical(struct btrfs_raid_bio *rbio, int sector_nr,
> sector->uptodate = 1;
> }
> if (failb >= 0) {
> - ret = verify_one_sector(rbio, faila, sector_nr);
> + ret = verify_one_sector(rbio, failb, sector_nr);
> if (ret < 0)
> goto cleanup;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] btrfs: raid56: Fix stripes if vertical errors are found
2023-01-15 20:32 [PATCH] btrfs: raid56: Fix stripes if vertical errors are found Tanmay Bhushan
2023-01-15 23:37 ` Qu Wenruo
@ 2023-01-25 19:11 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2023-01-25 19:11 UTC (permalink / raw)
To: Tanmay Bhushan
Cc: Chris Mason, Josef Bacik, David Sterba, linux-btrfs, linux-kernel
On Sun, Jan 15, 2023 at 09:32:15PM +0100, Tanmay Bhushan wrote:
> We take two stripe numbers if vertical errors are found.
> In case it is just a pstripe it does not matter but in
> case of raid 6 it matters a both stripes need to be fixed.
>
> Signed-off-by: Tanmay Bhushan <007047221b@gmail.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-25 19:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-15 20:32 [PATCH] btrfs: raid56: Fix stripes if vertical errors are found Tanmay Bhushan
2023-01-15 23:37 ` Qu Wenruo
2023-01-25 19:11 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).