From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 06/12] btrfs: move the compress_type check out of btrfs_bio_add_page
Date: Tue, 28 Feb 2023 14:13:43 +0100 [thread overview]
Message-ID: <20230228131343.GA25954@lst.de> (raw)
In-Reply-To: <4ef88b3e-1352-e3ca-9e5a-a139ba30c498@wdc.com>
On Tue, Feb 28, 2023 at 09:02:42AM +0000, Johannes Thumshirn wrote:
> Sh*t, then at least let's document that with a comment. Otherwise someone
> will see the code and try to clean it up and possibly break it.
I'll literally blow up on the first compression xfstests.
next prev parent reply other threads:[~2023-02-28 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 15:16 cleanup submit_extent_page and friends v2 Christoph Hellwig
2023-02-27 15:16 ` [PATCH 01/12] btrfs: don't set force_bio_submit in read_extent_buffer_subpage Christoph Hellwig
2023-02-27 16:05 ` Johannes Thumshirn
2023-02-27 15:16 ` [PATCH 02/12] btrfs: remove the force_bio_submit to submit_extent_page Christoph Hellwig
2023-02-27 15:16 ` [PATCH 03/12] btrfs: store the bio opf in struct btrfs_bio_ctrl Christoph Hellwig
2023-02-27 15:16 ` [PATCH 04/12] btrfs: remove the sync_io flag " Christoph Hellwig
2023-02-27 15:16 ` [PATCH 05/12] btrfs: add a wbc pointer to " Christoph Hellwig
2023-02-27 15:16 ` [PATCH 06/12] btrfs: move the compress_type check out of btrfs_bio_add_page Christoph Hellwig
2023-02-27 16:20 ` Johannes Thumshirn
2023-02-28 2:58 ` Christoph Hellwig
2023-02-28 9:02 ` Johannes Thumshirn
2023-02-28 13:13 ` Christoph Hellwig [this message]
2023-02-27 15:16 ` [PATCH 07/12] btrfs: rename the this_bio_flag variable in btrfs_do_readpage Christoph Hellwig
2023-02-27 15:17 ` [PATCH 08/12] btrfs: remove the compress_type argument to submit_extent_page Christoph Hellwig
2023-02-27 15:17 ` [PATCH 09/12] btrfs: remove the submit_extent_page return value Christoph Hellwig
2023-02-27 15:17 ` [PATCH 10/12] btrfs: simplify the error handling in __extent_writepage_io Christoph Hellwig
2023-02-27 15:17 ` [PATCH 11/12] btrfs: check for contiguity in submit_extent_page Christoph Hellwig
2023-02-27 15:17 ` [PATCH 12/12] btrfs: simplify submit_extent_page Christoph Hellwig
2023-02-27 21:21 ` cleanup submit_extent_page and friends v2 David Sterba
-- strict thread matches above, loose matches on Subject: below --
2023-02-16 16:34 cleanup submit_extent_page and friends Christoph Hellwig
2023-02-16 16:34 ` [PATCH 06/12] btrfs: move the compress_type check out of btrfs_bio_add_page Christoph Hellwig
2023-02-17 12:04 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228131343.GA25954@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox