From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: "Tomasz Kłoczko" <kloczko.tomasz@gmail.com>,
"David Sterba" <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: Btrfs progs release 6.2
Date: Wed, 1 Mar 2023 02:35:47 +0100 [thread overview]
Message-ID: <20230301013546.GU10580@suse.cz> (raw)
In-Reply-To: <a6fbb53a-f5bd-3d01-5944-1e7dfe60985e@gmx.com>
On Wed, Mar 01, 2023 at 08:30:05AM +0800, Qu Wenruo wrote:
>
>
> On 2023/3/1 08:15, David Sterba wrote:
> > On Wed, Mar 01, 2023 at 08:17:59AM +0800, Qu Wenruo wrote:
> >> On 2023/3/1 07:07, Tomasz Kłoczko wrote:
> >>> On Tue, 28 Feb 2023 at 20:07, David Sterba <dsterba@suse.com> wrote:
> >> cmds/property.o cmds/filesystem-usage.o cmds/inspect-dump-tree.o
> >> cmds/inspect-dump-super.o cmds/inspect-tree-stats.o cmds/filesystem-du.o
> >> cmds/reflink.o mkfs/common.o check/mode-common.o check/mode-lowmem.o
> >> check/clear-cache.o libbtrfsutil.a -rdynamic -L. -luuid -lblkid
> >> -ludev -L. -pthread -lz -llzo2 -lzstd
> >>
> >> According to the Makefile, it looks like Fedora build is not using the
> >> built-in crypto code.
> >>
> >> If using libsodium, I got the same error, as libsodium goes a different
> >> name for its blake2b_init (crypto_generichash_blake2b_init).
> >
> > Oh right, thanks, I can reproduce it now.
>
> And bisection points to the following two patches:
>
> bbf703bfd3f68958d33d139eb22057ab397e6c68 btrfs-progs: crypto: call
> sha256 implementations by pointer
> d1c366ee42bd3d2abb4fd855ac4a496b720d8bb6 btrfs-progs: crypto: call
> blake2 implementations by pointer
Yeah I know, I did some last minute changes to the commits because 32bit
builds on intel and arm failed due to the flag and feature detection.
The fix is not straightforward but now I have something that works.
next prev parent reply other threads:[~2023-03-01 1:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 19:23 Btrfs progs release 6.2 David Sterba
2023-02-28 22:46 ` Neal Gompa
2023-02-28 23:02 ` David Sterba
2023-03-01 2:51 ` Neal Gompa
2023-02-28 23:07 ` Tomasz Kłoczko
2023-03-01 0:17 ` Qu Wenruo
2023-03-01 0:15 ` David Sterba
2023-03-01 0:30 ` Qu Wenruo
2023-03-01 1:35 ` David Sterba [this message]
2023-03-01 13:00 ` Qu Wenruo
2023-03-01 18:07 ` David Sterba
2023-03-01 18:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301013546.GU10580@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=kloczko.tomasz@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox