From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD4EC64EC4 for ; Thu, 9 Mar 2023 15:21:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230498AbjCIPVr (ORCPT ); Thu, 9 Mar 2023 10:21:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230011AbjCIPVq (ORCPT ); Thu, 9 Mar 2023 10:21:46 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50D93E6834 for ; Thu, 9 Mar 2023 07:21:45 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id B801268AA6; Thu, 9 Mar 2023 16:21:42 +0100 (CET) Date: Thu, 9 Mar 2023 16:21:42 +0100 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , "linux-btrfs@vger.kernel.org" Subject: Re: [PATCH 04/20] btrfs: always read the entire extent_buffer Message-ID: <20230309152142.GD17952@lst.de> References: <20230309090526.332550-1-hch@lst.de> <20230309090526.332550-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Mar 09, 2023 at 11:29:54AM +0000, Johannes Thumshirn wrote: > Can someone smarter than me explain why we need to iterate eb->pages four > times in this function? This doesn't look super efficient to me. We don't, and only a single iteration is left by the end of the series :)