From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1CAC6FD1C for ; Tue, 14 Mar 2023 06:13:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229909AbjCNGNC (ORCPT ); Tue, 14 Mar 2023 02:13:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbjCNGNC (ORCPT ); Tue, 14 Mar 2023 02:13:02 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1661F64B16 for ; Mon, 13 Mar 2023 23:13:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 8059168AA6; Tue, 14 Mar 2023 07:12:57 +0100 (CET) Date: Tue, 14 Mar 2023 07:12:57 +0100 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 17/20] btrfs: don't check for uptodate pages in read_extent_buffer_pages Message-ID: <20230314061257.GE25047@lst.de> References: <20230309090526.332550-1-hch@lst.de> <20230309090526.332550-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Mar 10, 2023 at 05:08:17PM +0800, Qu Wenruo wrote: > Can we rely completely on EXTENT_BUFFER_UPTODATE flag and getting rid of > PateUptodate for metadata? I looked into this a bit, and think without stopping to use the page cache entirely (which I want to get to eventually) this causes more trouble than it solves. So I've skipped it for this series, but eventually there will be another round of massive simplifications here.