From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] btrfs: fix fast csum detection
Date: Tue, 4 Apr 2023 19:13:23 +0200 [thread overview]
Message-ID: <20230404171323.GD19619@suse.cz> (raw)
In-Reply-To: <ZCuwSBClLwjkPkzs@infradead.org>
On Mon, Apr 03, 2023 at 10:06:16PM -0700, Christoph Hellwig wrote:
> > > + if (btrfs_csum_is_fast(csum_type))
> > > + set_bit(BTRFS_FS_CSUM_IMPL_FAST, &fs_info->flags);
> >
> > This ^^^
> >
> > > fs_info->csum_size = btrfs_super_csum_size(disk_super);
> > >
> > > ret = btrfs_init_csum_hash(fs_info, csum_type);
> >
> > should be moved after the initialization btrfs_init_csum_hash so it
> > would also detect accelerated implementation of other hashes.
>
> Sure. Something like this incremental fix. Do you want to fold it in
> or should I resend the series?
I ended up with the same diff when reviewing the patch so I can fold it,
no need to resend. I'll send a separate patch to add xxhash as a fast
implementation, with some numbers.
next prev parent reply other threads:[~2023-04-04 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 0:13 don't offload CRCs generation to helpers if it is fast Christoph Hellwig
2023-03-29 0:13 ` [PATCH 1/4] btrfs: fix fast csum detection Christoph Hellwig
2023-04-03 18:35 ` David Sterba
2023-04-04 5:06 ` Christoph Hellwig
2023-04-04 17:13 ` David Sterba [this message]
2023-03-29 0:13 ` [PATCH 2/4] btrfs: remove the sync_writers field in struct btrfs_inode Christoph Hellwig
2023-04-05 13:50 ` David Sterba
2023-03-29 0:13 ` [PATCH 3/4] btrfs: never defer I/O submission for fast CRC implementations Christoph Hellwig
2023-03-29 0:13 ` [PATCH 4/4] btrfs: remove hipri_workers workqueue Christoph Hellwig
2023-03-30 15:42 ` don't offload CRCs generation to helpers if it is fast Chris Mason
2023-03-30 21:06 ` Christoph Hellwig
2023-03-31 17:31 ` David Sterba
2023-04-05 23:14 ` David Sterba
2023-04-06 5:23 ` Christoph Hellwig
2023-04-10 17:17 ` Christoph Hellwig
2023-04-11 19:09 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404171323.GD19619@suse.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox