From: Zorro Lang <zlang@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-unionfs@vger.kernel.org,
jack@suse.com, linux-xfs@vger.kernel.org, fdmanana@suse.com,
ebiggers@google.com, brauner@kernel.org, amir73il@gmail.com,
djwong@kernel.org, anand.jain@oracle.com
Subject: [PATCH 2/5] tools/get_maintainer.pl: remove penguin chiefs
Date: Wed, 5 Apr 2023 01:14:08 +0800 [thread overview]
Message-ID: <20230404171411.699655-3-zlang@kernel.org> (raw)
In-Reply-To: <20230404171411.699655-1-zlang@kernel.org>
There's not penguin chiefs in fstests, so remove related code.
Signed-off-by: Zorro Lang <zlang@kernel.org>
---
tools/get_maintainer.pl | 45 +----------------------------------------
1 file changed, 1 insertion(+), 44 deletions(-)
diff --git a/tools/get_maintainer.pl b/tools/get_maintainer.pl
index 376c7c02..671ffe26 100755
--- a/tools/get_maintainer.pl
+++ b/tools/get_maintainer.pl
@@ -31,7 +31,6 @@ my $email_fixes = 1;
my $email_list = 1;
my $email_moderated_list = 1;
my $email_subscriber_list = 0;
-my $email_git_penguin_chiefs = 0;
my $email_git = 0;
my $email_git_all_signature_types = 0;
my $email_git_blame = 0;
@@ -79,19 +78,6 @@ my @file_emails = ();
my %commit_author_hash;
my %commit_signer_hash;
-my @penguin_chief = ();
-push(@penguin_chief, "Zorro Lang:zlang\@kernel.org");
-
-my @penguin_chief_names = ();
-foreach my $chief (@penguin_chief) {
- if ($chief =~ m/^(.*):(.*)/) {
- my $chief_name = $1;
- my $chief_addr = $2;
- push(@penguin_chief_names, $chief_name);
- }
-}
-my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
-
# Signature types of people who are either
# a) responsible for the code in question, or
# b) familiar enough with it to give relevant feedback
@@ -242,7 +228,6 @@ if (!GetOptions(
'git-blame!' => \$email_git_blame,
'git-blame-signatures!' => \$email_git_blame_signatures,
'git-fallback!' => \$email_git_fallback,
- 'git-chief-penguins!' => \$email_git_penguin_chiefs,
'git-min-signatures=i' => \$email_git_min_signatures,
'git-max-maintainers=i' => \$email_git_max_maintainers,
'git-min-percent=i' => \$email_git_min_percent,
@@ -327,7 +312,7 @@ if ($sections || $letters ne "") {
if ($email &&
($email_maintainer + $email_reviewer +
$email_list + $email_subscriber_list +
- $email_git + $email_git_penguin_chiefs + $email_git_blame) == 0) {
+ $email_git + $email_git_blame) == 0) {
die "$P: Please select at least 1 email option\n";
}
@@ -967,19 +952,6 @@ sub get_maintainers {
}
if ($email) {
- foreach my $chief (@penguin_chief) {
- if ($chief =~ m/^(.*):(.*)/) {
- my $email_address;
-
- $email_address = format_email($1, $2, $email_usename);
- if ($email_git_penguin_chiefs) {
- push(@email_to, [$email_address, 'chief penguin']);
- } else {
- @email_to = grep($_->[0] !~ /${email_address}/, @email_to);
- }
- }
- }
-
foreach my $email (@file_emails) {
$email = mailmap_email($email);
my ($name, $address) = parse_email($email);
@@ -1041,7 +1013,6 @@ MAINTAINER field selection options:
--git-all-signature-types => include signers regardless of signature type
or use only ${signature_pattern} signers (default: $email_git_all_signature_types)
--git-fallback => use git when no exact MAINTAINERS pattern (default: $email_git_fallback)
- --git-chief-penguins => include ${penguin_chiefs}
--git-min-signatures => number of signatures required (default: $email_git_min_signatures)
--git-max-maintainers => maximum maintainers to add (default: $email_git_max_maintainers)
--git-min-percent => minimum percentage of commits required (default: $email_git_min_percent)
@@ -1289,8 +1260,6 @@ sub get_maintainer_role {
$role = "orphan minder";
} elsif ($role eq "obsolete") {
$role = "obsolete minder";
- } elsif ($role eq "buried alive in reporters") {
- $role = "chief penguin";
}
return $role . ":" . $subsystem;
@@ -1607,10 +1576,6 @@ sub vcs_find_signers {
save_commits_by_author(@lines) if ($interactive);
save_commits_by_signer(@lines) if ($interactive);
- if (!$email_git_penguin_chiefs) {
- @signatures = grep(!/${penguin_chiefs}/i, @signatures);
- }
-
my ($author_ref, $authors_ref) = extract_formatted_signatures(@authors);
my ($types_ref, $signers_ref) = extract_formatted_signatures(@signatures);
@@ -1623,10 +1588,6 @@ sub vcs_find_author {
@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
- if (!$email_git_penguin_chiefs) {
- @lines = grep(!/${penguin_chiefs}/i, @lines);
- }
-
return @lines if !@lines;
my @authors = ();
@@ -2342,10 +2303,6 @@ sub vcs_file_blame {
@lines = &{$VCS_cmds{"execute_cmd"}}($cmd);
- if (!$email_git_penguin_chiefs) {
- @lines = grep(!/${penguin_chiefs}/i, @lines);
- }
-
last if !@lines;
my @authors = ();
--
2.39.2
next prev parent reply other threads:[~2023-04-04 17:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 17:14 [RFC PATCH 0/5] fstests specific MAINTAINERS file Zorro Lang
2023-04-04 17:14 ` [PATCH 1/5] fstests: add MAINTAINERS and get_maintainer.pl files Zorro Lang
2023-04-04 23:21 ` Darrick J. Wong
2023-04-06 20:10 ` John Hubbard
2023-04-04 17:14 ` Zorro Lang [this message]
2023-04-04 17:14 ` [PATCH 3/5] fstests/MAINTAINERS: add supported mailing list Zorro Lang
2023-04-04 22:16 ` Eric Biggers
2023-04-04 23:22 ` Darrick J. Wong
2023-04-05 14:02 ` Zorro Lang
2023-04-04 23:21 ` Darrick J. Wong
2023-04-05 4:04 ` Steve French
2023-04-05 7:49 ` Christian Brauner
2023-04-05 9:52 ` Jan Kara
2023-04-06 0:25 ` Xiubo Li
2023-04-06 1:53 ` [f2fs-dev] " Chao Yu
2023-04-04 17:14 ` [PATCH 4/5] fstests/MAINTAINERS: add some specific reviewers Zorro Lang
2023-04-04 23:23 ` Darrick J. Wong
2023-04-05 7:47 ` Christian Brauner
2023-04-04 17:14 ` [PATCH 5/5] fstests/MAINTAINERS: add a co-maintainer for btrfs testing part Zorro Lang
2023-04-04 23:26 ` Darrick J. Wong
2023-04-06 14:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404171411.699655-3-zlang@kernel.org \
--to=zlang@kernel.org \
--cc=amir73il@gmail.com \
--cc=anand.jain@oracle.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=djwong@kernel.org \
--cc=ebiggers@google.com \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox