From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: "Анастасия Белова" <abelova@astralinux.ru>,
"Chris Mason" <clm@fb.com>, "Josef Bacik" <josef@toxicpanda.com>,
"David Sterba" <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] btrfs: parent bytenr must be aligned to sector size
Date: Fri, 28 Apr 2023 18:44:25 +0200 [thread overview]
Message-ID: <20230428164425.GD2654@twin.jikos.cz> (raw)
In-Reply-To: <8fb6638f-1e99-a1c1-3fa1-f814d08d2659@suse.com>
On Wed, Apr 26, 2023 at 08:25:14PM +0800, Qu Wenruo wrote:
>
>
> On 2023/4/26 19:53, Анастасия Белова wrote:
> > From: Anastasia Belova <abelova@astralinux.ru>
> >
> > Change nodesize to sectorsize in alignment check
> > in print_extent_item. Change requirement in comment.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Fixes: ea57788eb76d ("btrfs: require only sector size alignment for parent eb bytenr")
> > Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
>
> A little surprised that a static checker can even find such hidden problem.
I've seen in Coverity a fuzzy report like "there are 8 cases that do
thing X and this one does not, is it expected?" which is basically just
pattern matching but can be caused by copy&paste mistakes.
next prev parent reply other threads:[~2023-04-28 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 11:53 [PATCH] btrfs: parent bytenr must be aligned to sector size Анастасия Белова
2023-04-26 12:25 ` Qu Wenruo
2023-04-28 16:44 ` David Sterba [this message]
2023-04-28 16:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428164425.GD2654@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=abelova@astralinux.ru \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox