From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA05C77B61 for ; Fri, 28 Apr 2023 07:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345323AbjD1HfG (ORCPT ); Fri, 28 Apr 2023 03:35:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229981AbjD1HfF (ORCPT ); Fri, 28 Apr 2023 03:35:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0C5F26B9; Fri, 28 Apr 2023 00:35:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6797161050; Fri, 28 Apr 2023 07:35:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77A17C433EF; Fri, 28 Apr 2023 07:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1682667301; bh=HtXEKyZ+SeW3yKVP526Ucm0QpU6JFEOGDSj9KpDTkVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XrxdkVhL0B+9dFgyS5EtFVko1FawTCdRD9Ijs1CjYMg9NTmMBYlMCIqzfyn/fLok5 tj7Mq1NRwYV8S6HpYNlgVP/mk6Y79wEFWGPzeoYwaUC0IYrOKleHxnngKLGbhaeU2b nzaayA78kjvuBx+G91MQovDZVoTjzwamOFSXXzpE= Date: Fri, 28 Apr 2023 09:34:58 +0200 From: Greg Kroah-Hartman To: Ammar Faizi Cc: David Sterba , stable@vger.kernel.org, Linus Torvalds , David Sterba , Qu Wenruo , Josef Bacik , Memet , Linux Btrfs Mailing List , Linux Kernel Mailing List , GNU/Weeb Mailing List Subject: Re: [GIT PULL] Btrfs updates for 6.3 Message-ID: <2023042839-cube-snowflake-0721@gregkh> References: <4b35f3a4-9972-b7f0-287f-165a817c0f73@gnuweeb.org> <20230425145412.GC19619@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Apr 28, 2023 at 10:14:58AM +0700, Ammar Faizi wrote: > On Tue, Apr 25, 2023 at 04:54:12PM +0200, David Sterba wrote: > > On Sun, Apr 23, 2023 at 09:27:30AM +0700, Ammar Faizi wrote: > > > On 2/21/23 4:02 AM, Linus Torvalds wrote: > > > > On Mon, Feb 20, 2023 at 11:26 AM David Sterba wrote: > > > >> Other: > > > >> > > > >> - locally enable -Wmaybe-uninitialized after fixing all warnings > > > > > > > > I've pulled this, but I strongly suspect this change will get reverted. > > > > > > > > I bet neither you nor linux-next is testing even _remotely_ a big > > > > chunk of the different compiler versions that are out there, and the > > > > reason flags like '-Wmaybe-uninitialized' get undone is because some > > > > random compiler version on some random config and target archiecture > > > > gives completely nonsensical warnings for odd reasons. > > > > > > > > But hey, maybe the btrfs code is special. > > > > > > Maybe it's too late for 6.3. So please fix this in 6.4 and backport it to > > > 6.3 stable. > > > > Fix for this warning is in 6.4 pull request, there's no CC:stable tag > > but we can ask to add it once the code lands in master. > > It landed in master. > > [ Adding stable team to the Cc list ] > > Hi Greg and stable team, could you please backport: > > commit 8ba7d5f5ba931be68a94b8c91bcced1622934e7a upstream > ("btrfs: fix uninitialized variable warnings") > > to v6.3 to fix gcc (10, 9, 7) build error? > > The fs/btrfs/volumes.c hunk won't apply cleanly, but it can auto-merge: > > $ git cherry-pick 8ba7d5f5ba931be68a94b8c91bcced1622934e7a > Auto-merging fs/btrfs/volumes.c > [detached HEAD 572410288a1070c1] btrfs: fix uninitialized variable warnings > Author: Genjian Zhang > Date: Fri Mar 24 10:08:38 2023 +0800 > 2 files changed, 2 insertions(+), 2 deletions(-) Now queued up, thanks. greg k-h