From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EFB9C77B75 for ; Tue, 9 May 2023 13:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235441AbjEINMu (ORCPT ); Tue, 9 May 2023 09:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235396AbjEINMt (ORCPT ); Tue, 9 May 2023 09:12:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0361BC9 for ; Tue, 9 May 2023 06:12:48 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C395168D05; Tue, 9 May 2023 15:12:44 +0200 (CEST) Date: Tue, 9 May 2023 15:12:44 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , "linux-btrfs@vger.kernel.org" Subject: Re: [PATCH 17/21] btrfs: add a btrfs_finish_ordered_extent helper Message-ID: <20230509131244.GA32049@lst.de> References: <20230508160843.133013-1-hch@lst.de> <20230508160843.133013-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, May 09, 2023 at 12:22:39AM +0000, Johannes Thumshirn wrote: > > + show_root_type(__entry->root_objectid), > > + __entry->ino, __entry->start, > > + __entry->len, __entry->uptodate) > > +); > > Why can't we use the btrfs__ordered_extent event class here? We could. We'd lose the information on the range of the ordered_extent that actually is being completed. If the maintainers are ok with not having that in the trace point we can drop the separate implementation.