Re: simplify extent_buffer reading and writing v4

[Josef Bacik <josef@toxicpanda.com>]

On Wed, May 03, 2023 at 05:24:20PM +0200, Christoph Hellwig wrote:
> Hi all,
> 
> currently reading and writing of extent_buffers is very complicated as it
> tries to work in a page oriented way.  Switch as much as possible to work
> based on the extent_buffer object to simplify the code.
> 
> I suspect in the long run switching to dedicated object based writeback
> and reclaim similar to the XFS buffer cache would be a good idea, but as
> that involves pretty big behavior changes that's better left for a
> separate series.
> 
> Changes since v3:
>  - rebased to the latest misc-next tree
>  - remove a spurious ClearPageError call
> 
> Changes since v2:
>  - fix a commit message typo
>  - don't use simplify in commit message titles
> 
> Changes since v1:
>  - fix a pre-existing bug clearing the uptodate bit for subpage eb
>    write errors
>  - clean up extent_buffer_write_end_io a bit more
> 
> Diffstat:
>  compression.c |    4 
>  compression.h |    2 
>  disk-io.c     |  276 +++-----------------------
>  disk-io.h     |    5 
>  extent_io.c   |  606 ++++++++++++++--------------------------------------------
>  extent_io.h   |    3 
>  6 files changed, 197 insertions(+), 699 deletions(-)

There's the one whitespace thing that needs to be fixed, but otherwise this
series is great, thanks Christoph, you can add

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef