From: Christoph Hellwig <hch@lst.de>
To: David Sterba <dsterba@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 10/21] btrfs: return bool from lock_extent_buffer_for_io
Date: Wed, 24 May 2023 07:44:49 +0200 [thread overview]
Message-ID: <20230524054449.GA19255@lst.de> (raw)
In-Reply-To: <20230523184317.GY32559@twin.jikos.cz>
On Tue, May 23, 2023 at 08:43:17PM +0200, David Sterba wrote:
> On Wed, May 03, 2023 at 05:24:30PM +0200, Christoph Hellwig wrote:
> > lock_extent_buffer_for_io never returns a negative error value, so switch
> > the return value to a simple bool. Also remove the noinline_for_stack
> > annotation given that nothing in lock_extent_buffer_for_io or its callers
> > is particularly stack hungry.
>
> AFAIK the reason for noinline_for_stack is not because of a function is
> stack hungry but because we want to prevent inlining it so we can see it
> on stack in case there's an implied waiting. This makes it easier to
> debug when IO is stuck or there's some deadlock.
>
> This is not consistent in btrfs code though, quick search shows lots of
> historical noinline_for_stack everywhere without an obvious reason.
Hmm. noinline_for_stack is explicitly documented to only exist as an
annotation that noinline is used for stack usage. So this is very odd.
If you want a normal noinline here I can add one, but to be honest
I don't really see the point even for stack traces.
next prev parent reply other threads:[~2023-05-24 5:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 15:24 simplify extent_buffer reading and writing v4 Christoph Hellwig
2023-05-03 15:24 ` [PATCH 01/21] btrfs: mark extent_buffer_under_io static Christoph Hellwig
2023-05-03 15:24 ` [PATCH 02/21] btrfs: fix sub-page error handling in end_bio_subpage_eb_writepage Christoph Hellwig
2023-05-03 15:24 ` [PATCH 03/21] btrfs: move setting the buffer uptodate out of validate_extent_buffer Christoph Hellwig
2023-05-03 15:24 ` [PATCH 04/21] btrfs: merge verify_parent_transid and btrfs_buffer_uptodate Christoph Hellwig
2023-05-03 15:24 ` [PATCH 05/21] btrfs: always read the entire extent_buffer Christoph Hellwig
2023-05-03 15:24 ` [PATCH 06/21] btrfs: don't use btrfs_bio_ctrl for extent buffer reading Christoph Hellwig
2023-05-03 15:24 ` [PATCH 07/21] btrfs: remove the mirror_num argument to btrfs_submit_compressed_read Christoph Hellwig
2023-05-03 15:24 ` [PATCH 08/21] btrfs: use a separate end_io handler for read_extent_buffer Christoph Hellwig
2023-05-03 15:24 ` [PATCH 09/21] btrfs: do not try to unlock the extent for non-subpage metadata reads Christoph Hellwig
2023-05-03 15:24 ` [PATCH 10/21] btrfs: return bool from lock_extent_buffer_for_io Christoph Hellwig
2023-05-23 18:43 ` David Sterba
2023-05-24 5:44 ` Christoph Hellwig [this message]
2023-05-26 13:34 ` David Sterba
2023-05-03 15:24 ` [PATCH 11/21] btrfs: submit a writeback bio per extent_buffer Christoph Hellwig
2023-05-03 15:24 ` [PATCH 12/21] btrfs: move page locking from lock_extent_buffer_for_io to write_one_eb Christoph Hellwig
2023-05-03 15:24 ` [PATCH 13/21] btrfs: don't use btrfs_bio_ctrl for extent buffer writing Christoph Hellwig
2023-05-23 18:45 ` David Sterba
2023-05-24 5:50 ` Christoph Hellwig
2023-05-26 13:15 ` David Sterba
2023-05-26 13:35 ` Christoph Hellwig
2023-05-03 15:24 ` [PATCH 14/21] btrfs: use a separate end_io handler for extent_buffer writing Christoph Hellwig
2023-05-11 15:02 ` Josef Bacik
2023-05-03 15:24 ` [PATCH 15/21] btrfs: remove the extent_buffer lookup in btree block checksumming Christoph Hellwig
2023-05-26 6:39 ` Qu Wenruo
2023-05-26 6:41 ` Christoph Hellwig
2023-05-26 6:43 ` Qu Wenruo
2023-05-26 7:03 ` Christoph Hellwig
2023-05-26 7:25 ` Qu Wenruo
2023-05-26 13:58 ` David Sterba
2023-05-03 15:24 ` [PATCH 16/21] btrfs: remove the io_pages field in struct extent_buffer Christoph Hellwig
2023-05-03 15:24 ` [PATCH 17/21] btrfs: stop using PageError for extent_buffers Christoph Hellwig
2023-05-03 15:24 ` [PATCH 18/21] btrfs: don't check for uptodate pages in read_extent_buffer_pages Christoph Hellwig
2023-05-03 15:24 ` [PATCH 19/21] btrfs: stop using lock_extent in btrfs_buffer_uptodate Christoph Hellwig
2023-05-03 15:24 ` [PATCH 20/21] btrfs: use per-buffer locking for extent_buffer reading Christoph Hellwig
2023-05-03 15:24 ` [PATCH 21/21] btrfs: merge write_one_subpage_eb into write_one_eb Christoph Hellwig
2023-05-11 15:08 ` simplify extent_buffer reading and writing v4 Josef Bacik
2023-05-23 19:42 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2023-03-30 6:30 simplify extent_buffer reading and writing v3 Christoph Hellwig
2023-03-30 6:30 ` [PATCH 10/21] btrfs: return bool from lock_extent_buffer_for_io Christoph Hellwig
2023-03-14 6:16 simplify extent_buffer reading and writing v2 Christoph Hellwig
2023-03-14 6:16 ` [PATCH 10/21] btrfs: return bool from lock_extent_buffer_for_io Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524054449.GA19255@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox