From: Christoph Hellwig <hch@lst.de>
To: David Sterba <dsterba@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 08/16] btrfs: stop setting PageError in the data I/O path
Date: Tue, 30 May 2023 16:24:45 +0200 [thread overview]
Message-ID: <20230530142445.GB9014@lst.de> (raw)
In-Reply-To: <20230530132311.GQ575@twin.jikos.cz>
On Tue, May 30, 2023 at 03:23:11PM +0200, David Sterba wrote:
> On Tue, May 23, 2023 at 10:13:14AM +0200, Christoph Hellwig wrote:
> > Note that the error propagation for superblock writes still uses
> > PageError for now.
>
> This patchset cleans up all the other Error bits so for super block we
> can first switch to another flag like PageChecked, reworking the
> separate page for superblock I tired some time ago still had problems.
Yes. But the superblock writing all works based on the block devices
page cache, so it doesn't interact with the per-normal file pagecache
touched here, or the magic btree inode page cache touched in the
previous series. I was planning to take a closer look at the
superblock handling when I find some time.
next prev parent reply other threads:[~2023-05-30 14:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 8:13 writeback fixlets and tidyups Christoph Hellwig
2023-05-23 8:13 ` [PATCH 01/16] btrfs: fix range_end calculation in extent_write_locked_range Christoph Hellwig
2023-05-29 17:13 ` David Sterba
2023-05-30 13:13 ` David Sterba
2023-05-30 14:23 ` Christoph Hellwig
2023-05-23 8:13 ` [PATCH 02/16] btrfs: factor out a btrfs_verify_page helper Christoph Hellwig
2023-05-23 9:23 ` Qu Wenruo
2023-05-23 11:38 ` Christoph Hellwig
2023-05-23 10:16 ` Anand Jain
2023-05-23 11:39 ` Christoph Hellwig
2023-05-23 11:47 ` Anand Jain
2023-05-23 11:54 ` Christoph Hellwig
2023-05-29 17:34 ` David Sterba
2023-05-23 8:13 ` [PATCH 03/16] btrfs: unify fsverify vs other read error handling in end_page_read Christoph Hellwig
2023-05-29 17:39 ` David Sterba
2023-05-23 8:13 ` [PATCH 04/16] btrfs: don't check PageError in btrfs_verify_page Christoph Hellwig
2023-05-23 8:13 ` [PATCH 05/16] btrfs: don't fail writeback when allocating the compression context fails Christoph Hellwig
2023-05-23 8:13 ` [PATCH 06/16] btrfs: rename cow_file_range_async to run_delalloc_compressed Christoph Hellwig
2023-05-23 10:23 ` Anand Jain
2023-05-23 8:13 ` [PATCH 07/16] btrfs: don't check PageError in __extent_writepage Christoph Hellwig
2023-05-23 8:13 ` [PATCH 08/16] btrfs: stop setting PageError in the data I/O path Christoph Hellwig
2023-05-29 17:52 ` David Sterba
2023-05-30 5:45 ` Christoph Hellwig
2023-05-30 6:08 ` Matthew Wilcox
2023-05-30 13:34 ` David Sterba
2023-05-30 14:26 ` Christoph Hellwig
2023-05-30 13:23 ` David Sterba
2023-05-30 14:24 ` Christoph Hellwig [this message]
2023-05-23 8:13 ` [PATCH 09/16] btrfs: remove PAGE_SET_ERROR Christoph Hellwig
2023-05-23 8:13 ` [PATCH 10/16] btrfs: remove non-standard extent handling in __extent_writepage_io Christoph Hellwig
2023-05-23 8:13 ` [PATCH 11/16] btrfs: move nr_to_write to __extent_writepage Christoph Hellwig
2023-05-23 10:30 ` Anand Jain
2023-05-23 8:13 ` [PATCH 12/16] btrfs: only call __extent_writepage_io from extent_write_locked_range Christoph Hellwig
2023-05-23 8:13 ` [PATCH 13/16] btrfs: don't treat zoned writeback as being from an async helper thread Christoph Hellwig
2023-05-23 8:13 ` [PATCH 14/16] btrfs: don't redirty the locked page for extent_write_locked_range Christoph Hellwig
2023-05-23 8:13 ` [PATCH 15/16] btrfs: refactor the zoned device handling in cow_file_range Christoph Hellwig
2023-05-23 8:13 ` [PATCH 16/16] btrfs: split page locking out of __process_pages_contig Christoph Hellwig
2023-05-23 23:27 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-05-31 6:04 writeback fixlets and tidyups v2 Christoph Hellwig
2023-05-31 6:04 ` [PATCH 08/16] btrfs: stop setting PageError in the data I/O path Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530142445.GB9014@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).