From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7109C77B73 for ; Tue, 30 May 2023 14:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232695AbjE3O0h (ORCPT ); Tue, 30 May 2023 10:26:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232729AbjE3O0K (ORCPT ); Tue, 30 May 2023 10:26:10 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA5AF11C for ; Tue, 30 May 2023 07:25:15 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4445468B05; Tue, 30 May 2023 16:24:45 +0200 (CEST) Date: Tue, 30 May 2023 16:24:45 +0200 From: Christoph Hellwig To: David Sterba Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 08/16] btrfs: stop setting PageError in the data I/O path Message-ID: <20230530142445.GB9014@lst.de> References: <20230523081322.331337-1-hch@lst.de> <20230523081322.331337-9-hch@lst.de> <20230530132311.GQ575@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530132311.GQ575@twin.jikos.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, May 30, 2023 at 03:23:11PM +0200, David Sterba wrote: > On Tue, May 23, 2023 at 10:13:14AM +0200, Christoph Hellwig wrote: > > Note that the error propagation for superblock writes still uses > > PageError for now. > > This patchset cleans up all the other Error bits so for super block we > can first switch to another flag like PageChecked, reworking the > separate page for superblock I tired some time ago still had problems. Yes. But the superblock writing all works based on the block devices page cache, so it doesn't interact with the per-normal file pagecache touched here, or the magic btree inode page cache touched in the previous series. I was planning to take a closer look at the superblock handling when I find some time.