From: Christoph Hellwig <hch@lst.de>
To: David Sterba <dsterba@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
"open list:BTRFS FILE SYSTEM" <linux-btrfs@vger.kernel.org>,
naohiro.aota@wdc.com
Subject: Re: [PATCH 3/3] btrfs: don't hold an extra reference for redirtied buffers
Date: Wed, 31 May 2023 06:16:26 +0200 [thread overview]
Message-ID: <20230531041626.GA32582@lst.de> (raw)
In-Reply-To: <20230530155648.GB30110@twin.jikos.cz>
On Tue, May 30, 2023 at 05:56:48PM +0200, David Sterba wrote:
> > > I'd appreciate more eyes on this patch, with the indirections and
> > > writeback involved it's not clear to me that we don't need the list at
> > > all.
> >
> > My suspicision is that Aoto-san wanted the extra safety of the extra
> > reference because he didn't want to trust or hadn't noticed the
> > extent_buffer_under_io() magic. Auto-san, can you confirm or deny? :)
>
> The number of patches above this one in the queue is increasing so it
> would get harder to remove it. I took another look and agree that
> regarding the references it's safe but would still like a confirmation.
As stated, I am very confident that this is safe based on all my
recent work with the extent_buffer code base. I'd love to hear
from Aota, but there's not much more I can add here myself.
next prev parent reply other threads:[~2023-05-31 4:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 14:58 buffer redirtying fixes and cleanup Christoph Hellwig
2023-05-08 14:58 ` [PATCH 1/3] btrfs: zero the buffer before marking it dirty in btrfs_redirty_list_add Christoph Hellwig
2023-05-08 14:58 ` [PATCH 2/3] btrfs: fix dirty_metadata_bytes for redirtied buffers Christoph Hellwig
2023-05-08 14:58 ` [PATCH 3/3] btrfs: don't hold an extra reference " Christoph Hellwig
2023-05-09 22:57 ` David Sterba
2023-05-15 9:22 ` Christoph Hellwig
2023-05-30 15:56 ` David Sterba
2023-05-31 4:16 ` Christoph Hellwig [this message]
2023-05-31 15:04 ` Naohiro Aota
2023-06-05 15:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531041626.GA32582@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox